From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 7 Dec 2007 23:03:39 +0000 (-0000)
Subject: Bug #189417 - Explicitly whitelist any remaining variables that are
X-Git-Tag: v2.1.4~131
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=11928e96140ecac1e567a1fe364a1abc27eec705;p=portage.git

Bug #189417 - Explicitly whitelist any remaining variables that are
allowed to leak into the ebuild environment. Also, fix spawnebuild
to properly filter the env when it spawns misc-functions.sh after
the install phase. (trunk r8863:8867)

svn path=/main/branches/2.1.2/; revision=8868
---

diff --git a/pym/portage.py b/pym/portage.py
index 6538e0135..fad76b650 100644
--- a/pym/portage.py
+++ b/pym/portage.py
@@ -995,19 +995,38 @@ class config:
 
 	_environ_whitelist = []
 
-	# Preserve backupenv values that are initialized in the config
-	# constructor. Also, preserve XARGS since it is set by the
-	# portage.data module.
+	# Whitelisted variables are always allowed to enter the ebuild
+	# environment. Generally, this only includes special portage
+	# variables. Ebuilds can unset variables that are not whitelisted
+	# and rely on them remaining unset for future phases, without them
+	# leaking back in from various locations (bug #189417). It's very
+	# important to set our special BASH_ENV variable in the ebuild
+	# environment in order to prevent sandbox from sourcing /etc/profile
+	# in it's bashrc (causing major leakage).
 	_environ_whitelist += [
-		"DISTDIR", "FEATURES", "PORTAGE_BIN_PATH",
-		"PORTAGE_CONFIGROOT", "PORTAGE_DEPCACHEDIR",
+		"BASH_ENV", "BUILD_PREFIX", "D",
+		"DISTDIR", "DOC_SYMLINKS_DIR", "EBUILD_EXIT_STATUS_FILE",
+		"EBUILD", "EBUILD_PHASE", "ECLASSDIR", "ECLASS_DEPTH", "EMERGE_FROM",
+		"FEATURES", "FILESDIR", "HOME", "PATH",
+		"PKGUSE", "PKG_LOGDIR", "PKG_TMPDIR",
+		"PORTAGE_ACTUAL_DISTDIR", "PORTAGE_ARCHLIST",
+		"PORTAGE_BASHRC", "PORTAGE_BINPKG_TMPFILE", "PORTAGE_BIN_PATH",
+		"PORTAGE_BUILDDIR", "PORTAGE_COLORMAP",
+		"PORTAGE_CONFIGROOT", "PORTAGE_DEBUG", "PORTAGE_DEPCACHEDIR",
 		"PORTAGE_GID", "PORTAGE_INST_GID", "PORTAGE_INST_UID",
-		"PORTAGE_PYM_PATH", "PORTAGE_WORKDIR_MODE",
-		"PORTDIR", "PORTDIR_OVERLAY", "PREROOTPATH",
-		"ROOT", "ROOTPATH", "USE_ORDER",
+		"PORTAGE_LOG_FILE", "PORTAGE_MASTER_PID",
+		"PORTAGE_PYM_PATH", "PORTAGE_REPO_NAME", "PORTAGE_RESTRICT",
+		"PORTAGE_TMPDIR", "PORTAGE_WORKDIR_MODE",
+		"PORTDIR", "PORTDIR_OVERLAY", "PREROOTPATH", "PROFILE_PATHS",
+		"ROOT", "ROOTPATH", "STARTDIR", "T", "TMP", "TMPDIR",
+		"USE_EXPAND", "USE_ORDER", "WORKDIR",
 		"XARGS",
 	]
 
+	_environ_whitelist += [
+		"A", "AA", "CATEGORY", "P", "PF", "PN", "PR", "PV", "PVR"
+	]
+
 	# misc variables inherited from the calling environment
 	_environ_whitelist += [
 		"COLORTERM", "DISPLAY", "EDITOR", "LESS",
@@ -2564,9 +2583,11 @@ class config:
 			if filter_calling_env and \
 				x not in environ_whitelist and \
 				not self._environ_whitelist_re.match(x):
-				if myvalue == env_d.get(x) or \
-					myvalue == os.environ.get(x):
-					continue
+				# Do not allow anything to leak into the ebuild
+				# environment unless it is explicitly whitelisted.
+				# This ensures that variables unset by the ebuild
+				# remain unset.
+				continue
 			mydict[x] = myvalue
 		if not mydict.has_key("HOME") and mydict.has_key("BUILD_PREFIX"):
 			writemsg("*** HOME not set. Setting to "+mydict["BUILD_PREFIX"]+"\n")
@@ -3695,7 +3716,14 @@ def spawnebuild(mydo,actionmap,mysettings,debug,alwaysdep=0,logfile=None):
 				os.path.basename(MISC_SH_BINARY))
 			mycommand = " ".join([_shell_quote(misc_sh_binary),
 				"install_qa_check", "install_symlink_html_docs"])
-			qa_retval = spawn(mycommand, mysettings, debug=debug, logfile=logfile, **kwargs)
+			filter_calling_env_state = mysettings._filter_calling_env
+			if os.path.exists(os.path.join(mysettings["T"], "environment")):
+				mysettings._filter_calling_env = True
+			try:
+				qa_retval = spawn(mycommand, mysettings, debug=debug,
+					logfile=logfile, **kwargs)
+			finally:
+				mysettings._filter_calling_env = filter_calling_env_state
 			if qa_retval:
 				writemsg("!!! install_qa_check failed; exiting.\n",
 					noiselevel=-1)