From: Jakub Narebski <jnareb@gmail.com>
Date: Tue, 22 Aug 2006 17:05:24 +0000 (+0200)
Subject: gitweb: Drop the href() params which keys are not in %mapping
X-Git-Tag: v1.4.3-rc1~168^2~28
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1149fecfc270a2effc344897989f40afe449a72c;p=git.git

gitweb: Drop the href() params which keys are not in %mapping

If someone would enter parameter name incorrectly, and some key of
%params is not found in %mapping hash, the parameter is now
ignored. Change introduced by Martin Waitz in commit
  756d2f064b2419fcdf9cd9c851f352e2a4f75103
tried to do that, but it left empty value and there was doubled ";;"
in returned string.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 1c8a2ebe1..43b160048 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -285,7 +285,7 @@ sub href(%) {
 	my $href = "$my_uri?";
 	$href .= esc_param( join(";",
 		map {
-			"$mapping{$_}=$params{$_}" if defined $params{$_}
+			defined $params{$_} ? "$mapping{$_}=$params{$_}" : ()
 		} keys %params
 	) );