From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 30 Mar 2014 16:13:36 +0000 (+0300)
Subject: Re: [Patch v3] util: add gzreadline
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=113176ef1bd58eaa707c499ba6a4e8b6d037f37c;p=notmuch-archives.git

Re: [Patch v3] util: add gzreadline
---

diff --git a/d8/d38193d10416520bb3c091ac4b47139bc04e2a b/d8/d38193d10416520bb3c091ac4b47139bc04e2a
new file mode 100644
index 000000000..361858a25
--- /dev/null
+++ b/d8/d38193d10416520bb3c091ac4b47139bc04e2a
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 76B16431FBC
+	for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 09:13:52 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id PoIG7DtgKe08 for <notmuch@notmuchmail.org>;
+	Sun, 30 Mar 2014 09:13:44 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id B9A8D431FB6
+	for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 09:13:44 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 1CE1E10005E;
+	Sun, 30 Mar 2014 19:13:37 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [Patch v3] util: add gzreadline
+In-Reply-To: <877g7beos0.fsf@zancas.localnet>
+References: <m2zjk8um02.fsf@guru.guru-group.fi>
+	<1396178602-7583-1-git-send-email-david@tethera.net>
+	<m2txafvori.fsf@guru.guru-group.fi>
+	<877g7beos0.fsf@zancas.localnet>
+User-Agent: Notmuch/0.17+171~g9a127b7 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 30 Mar 2014 19:13:36 +0300
+Message-ID: <m2r45jwtov.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 30 Mar 2014 16:13:52 -0000
+
+On Sun, Mar 30 2014, David Bremner <david@tethera.net> wrote:
+
+> Tomi Ollila <tomi.ollila@iki.fi> writes:
+>
+>> "On error, gzgets() shall return Z_NULL.
+>>
+>> In light of this I'd say no. can we set out-of-memory using some public
+>> api so it is available using gzerror()
+>>
+>>
+>
+> Since we already "broke" the API, what about
+>
+> 1) start a "util_status_t" enum, later unify that with the hex_ return codes.
+>
+> 2) 
+>
+> util_status_t
+> gz_getline (void *ctx, char **buf, size_t *bufsize, ssize_t *bytes_read,
+>            gzFile stream);
+
+that looks unobjectionable to me :D
+
+>
+> d
+
+Tomi