From: Mark Walters Date: Tue, 21 May 2013 15:26:13 +0000 (+0100) Subject: Re: [PATCH 0/5] Make Emacs search use sexp format X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=10ca0b0f87319153c9e57f9e547d7677d569ce28;p=notmuch-archives.git Re: [PATCH 0/5] Make Emacs search use sexp format --- diff --git a/ed/2d1eb91903b80a89ba568715b94539a3d2a202 b/ed/2d1eb91903b80a89ba568715b94539a3d2a202 new file mode 100644 index 000000000..906beff5f --- /dev/null +++ b/ed/2d1eb91903b80a89ba568715b94539a3d2a202 @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1662B431FC7 + for ; Tue, 21 May 2013 08:26:25 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TZ0vCd2L3K+a for ; + Tue, 21 May 2013 08:26:17 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E7764431FB6 + for ; Tue, 21 May 2013 08:26:16 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1UeoS6-0000EQ-MD; Tue, 21 May 2013 16:26:15 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1UeoS6-0006B4-EK; Tue, 21 May 2013 16:26:14 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/5] Make Emacs search use sexp format +In-Reply-To: <1368851472-5382-1-git-send-email-amdragon@mit.edu> +References: <1368851472-5382-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 21 May 2013 16:26:13 +0100 +Message-ID: <87d2sk2w2y.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: a1f00f841d29b236a504cfc05f86d630 (of first 20000 bytes) +X-SpamAssassin-Score: -0.2 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.2 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.2 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 21 May 2013 15:26:25 -0000 + + +This whole series looks good to me (modulo the minor comments I have +made). The tests all pass. Additionally it was very simple to modify +notmuch-pick to use the new parser and that also seemed to work. + +Incidentally it seems that notmuch-show still uses the JSON format so we +may want to switch that over too. + +Best wishes + +Mark + + +On Sat, 18 May 2013, Austin Clements wrote: +> This series implements an incremental S-expression parser and switches +> search over to it. To simplify things, it also implements better +> handing of stderr for asynchronous processes so we don't have to +> handle errors embedded in the S-expression stream.