From: David Bremner <david@tethera.net>
Date: Fri, 2 Jan 2015 16:18:42 +0000 (+0100)
Subject: lib: convert two "iterator copy strings" into references.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=105537a809d1a385a3151de0c5b6235773782040;p=notmuch.git

lib: convert two "iterator copy strings" into references.

Apparently this is a supported and even idiomatic way of keeping a
temporary object (e.g. like that returned from an operator
dereference) alive.
---

diff --git a/lib/message.cc b/lib/message.cc
index bacb4d46..956a70a9 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -283,7 +283,7 @@ _notmuch_message_get_term (notmuch_message_t *message,
     if (i == end)
 	return NULL;
 
-    std::string term = *i;
+    const std::string &term = *i;
     if (strncmp (term.c_str(), prefix, prefix_len))
 	return NULL;
 
@@ -641,7 +641,7 @@ _notmuch_message_add_directory_terms (void *ctx, notmuch_message_t *message)
 	unsigned int directory_id;
 	const char *direntry, *directory;
 	char *colon;
-	const std::string term = *i;
+	const std::string &term = *i;
 
 	/* Terminate loop at first term without desired prefix. */
 	if (strncmp (term.c_str (), direntry_prefix, direntry_prefix_len))