From: David Bremner Date: Sun, 20 Sep 2015 12:43:59 +0000 (+2100) Subject: Re: [PATCH 3½/9] test: notmuch address --deduplicate=no tests X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=10215d95b6c047fed72f9dc5fcda83bd2972ef2a;p=notmuch-archives.git Re: [PATCH 3½/9] test: notmuch address --deduplicate=no tests --- diff --git a/09/bb963bdedb43ed07a76faa4f64de414cd8fba0 b/09/bb963bdedb43ed07a76faa4f64de414cd8fba0 new file mode 100644 index 000000000..162680904 --- /dev/null +++ b/09/bb963bdedb43ed07a76faa4f64de414cd8fba0 @@ -0,0 +1,93 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 1152B6DE1B2E + for ; Sun, 20 Sep 2015 07:30:33 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.113 +X-Spam-Level: +X-Spam-Status: No, score=0.113 tagged_above=-999 required=5 tests=[AWL=0.113] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qGe8Sy84P9eV for ; + Sun, 20 Sep 2015 07:30:31 -0700 (PDT) +Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id F141A6DE1B2C + for ; Sun, 20 Sep 2015 07:30:30 -0700 (PDT) +Received: from remotemail by gitolite.debian.net with local (Exim 4.80) + (envelope-from ) + id 1Zdex8-00075t-Gm; Sun, 20 Sep 2015 13:46:50 +0000 +Received: (nullmailer pid 4346 invoked by uid 1000); Sun, 20 Sep 2015 + 12:44:00 -0000 +From: David Bremner +To: Jani Nikula , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH =?utf-8?Q?3=C2=BD=2F9=5D?= test: notmuch address + --deduplicate=no tests +In-Reply-To: <1441391716-17282-1-git-send-email-jani@nikula.org> +References: + + <1441391716-17282-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sun, 20 Sep 2015 09:43:59 -0300 +Message-ID: <87a8shtg4w.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 20 Sep 2015 14:30:33 -0000 + +Jani Nikula writes: + +> Test not using address deduplication. Incorporate some trivial output +> sorting tests here, as they seem to lack tests. +> --- +> test/T095-address.sh | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++ +> 1 file changed, 70 insertions(+) +> +> diff --git a/test/T095-address.sh b/test/T095-address.sh +> index 8eecb2a6a7ba..f8d902cb3a5e 100755 +> --- a/test/T095-address.sh +> +++ b/test/T095-address.sh +> @@ -145,4 +145,74 @@ cat <EXPECTED +> EOF +> test_expect_equal_file OUTPUT EXPECTED +> +> +test_begin_subtest "--deduplicate=no --sort=oldest-first --output=sender" +> +notmuch address --deduplicate=no --sort=oldest-first --output=sender '*' >OUTPUT +> +cat <EXPECTED +> +Mikhail Gusarov +> +Mikhail Gusarov +> +Carl Worth + +> + +> +test_begin_subtest "--deduplicate=no --sort=newest-first --output=sender --output=recipients" +> +notmuch address --deduplicate=no --sort=newest-first --output=sender --output=recipients path:foo/new >OUTPUT +> +cat <EXPECTED +> +Mikhail Gusarov +> +notmuch@notmuchmail.org +> +Mikhail Gusarov + +Two comments: + +1) It's suprising that Mikail is first in both the newest-first and +oldest-first list. Is it easy to explain why? + +2) the use of path: term is not mentioned in the description. Should it +be mentioned somehow? + +d