From: Zac Medico <zmedico@gentoo.org>
Date: Sun, 28 Jun 2009 18:24:23 +0000 (-0000)
Subject: Bug #236786 - Warn about 'test?' USE conditionals in RDEPEND. Thanks to
X-Git-Tag: v2.2_rc34~134
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0db2a617938c50900e75cf52c767c3acf6647b76;p=portage.git

Bug #236786 - Warn about 'test?' USE conditionals in RDEPEND. Thanks to
Markus Meier <maekke@gentoo.org> for this patch.

svn path=/main/trunk/; revision=13724
---

diff --git a/bin/repoman b/bin/repoman
index 41c811039..09b79da23 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -1404,7 +1404,11 @@ for x in scanlist:
 			if mytype in ("DEPEND", "RDEPEND", "PDEPEND"):
 				for token in mydepstr.split():
 					if token in operator_tokens or \
-						token.endswith("?"):
+						token[-1:] == "?":
+						if token == "test?" and mytype == "RDEPEND":
+							stats['RDEPEND.suspect'] += 1
+							fails['RDEPEND.suspect'].append(relative_path + \
+								": 'test?' USE conditional in RDEPEND")
 						continue
 					try:
 						atom = portage.dep.Atom(token)