From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 29 Jan 2010 18:49:23 +0000 (-0000)
Subject: Don't bail out if postinst fails. Thanks to Brain Harring for the suggestion.
X-Git-Tag: v2.1.7.17~17
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0d828a8c65db74d175597bce2d5bb1d37109f068;p=portage.git

Don't bail out if postinst fails. Thanks to Brain Harring for the suggestion.
(trunk r15202)

svn path=/main/branches/2.1.7/; revision=15255
---

diff --git a/pym/portage/dbapi/vartree.py b/pym/portage/dbapi/vartree.py
index 13c9269a3..75558a12f 100644
--- a/pym/portage/dbapi/vartree.py
+++ b/pym/portage/dbapi/vartree.py
@@ -2847,11 +2847,11 @@ class dblink(object):
 		finally:
 			self.settings.pop("PORTAGE_UPDATE_ENV", None)
 
-		# XXX: Decide how to handle failures here.
 		if a != os.EX_OK:
+			# It's stupid to bail out here, so keep going regardless of
+			# phase return code.
 			showMessage(_("!!! FAILED postinst: ")+str(a)+"\n",
 				level=logging.ERROR, noiselevel=-1)
-			return a
 
 		downgrade = False
 		for v in otherversions: