From: Frank Lichtenheld <frank@lichtenheld.de>
Date: Sat, 31 Mar 2007 13:57:47 +0000 (+0200)
Subject: cvsserver: Use DBI->table_info instead of DBI->tables
X-Git-Tag: v1.5.2-rc0~34^2~6
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0cf611a300fbbbd12827f9defb9cbcc934a3b1d6;p=git.git

cvsserver: Use DBI->table_info instead of DBI->tables

DBI->table_info is portable across different DBD backends,
DBI->tables is not.

Limit the output to objects of type TABLE.

Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
---

diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index 941a91bca..5532ae7a3 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -2171,10 +2171,8 @@ sub new
     die "Error connecting to database\n" unless defined $self->{dbh};
 
     $self->{tables} = {};
-    foreach my $table ( $self->{dbh}->tables )
+    foreach my $table ( keys %{$self->{dbh}->table_info(undef,undef,undef,'TABLE')->fetchall_hashref('TABLE_NAME')} )
     {
-        $table =~ s/^"//;
-        $table =~ s/"$//;
         $self->{tables}{$table} = 1;
     }