From: Thomas Klausner Date: Thu, 26 Jun 2014 13:08:26 +0000 (+0200) Subject: notmuch-0.18 issues [was Re: notmuch-0.16: realpath() compatibility issue; clang... X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0cc538ecd7dccca1c24506a40f6e36e7e78f343b;p=notmuch-archives.git notmuch-0.18 issues [was Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem] --- diff --git a/32/1a82e82ef9badbc3c472969dd462a399d18f00 b/32/1a82e82ef9badbc3c472969dd462a399d18f00 new file mode 100644 index 000000000..47479e339 --- /dev/null +++ b/32/1a82e82ef9badbc3c472969dd462a399d18f00 @@ -0,0 +1,194 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2F22C431FAF + for ; Thu, 26 Jun 2014 06:08:41 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UkpSrFS-4us9 for ; + Thu, 26 Jun 2014 06:08:35 -0700 (PDT) +Received: from danbala.ifoer.tuwien.ac.at (danbala.ifoer.tuwien.ac.at + [128.130.168.64]) + by olra.theworths.org (Postfix) with ESMTP id 856CE431FAE + for ; Thu, 26 Jun 2014 06:08:34 -0700 (PDT) +Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116) + id C9BCEA4FC; Thu, 26 Jun 2014 15:08:26 +0200 (CEST) +Date: Thu, 26 Jun 2014 15:08:26 +0200 +From: Thomas Klausner +To: David Bremner +Subject: notmuch-0.18 issues [was Re: notmuch-0.16: realpath() compatibility + issue; clang visibility problem] +Message-ID: <20140626130826.GL11862@danbala.tuwien.ac.at> +References: <20140103214735.GG27614@danbala.tuwien.ac.at> + <87ob0c6p0e.fsf@zancas.localnet> + <20140408123312.GZ5053@danbala.tuwien.ac.at> + + <87a98zho9y.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: multipart/mixed; boundary="T4sUOijqQbZv57TR" +Content-Disposition: inline +In-Reply-To: <87a98zho9y.fsf@zancas.localnet> +Cc: Notmuch list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 26 Jun 2014 13:08:41 -0000 + + +--T4sUOijqQbZv57TR +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline + +Hi David! + +Thanks for getting back to me about this. +Currently configure (with some patches) says: + +Checking for Xapian development files... Yes (1.2.17). +Checking for Xapian compaction support... Yes. +Checking for GMime development files... Yes (gmime-2.4 ). +Checking for Glib development files (>= 2.22)... Yes. +Checking for zlib (>= 1.2.5.2)... Yes. +Checking for talloc development files... Yes. +Checking for valgrind development files... No (but that's fine). +Checking for bash-completion (>= 1.90)... No (will not install bash completion). +Checking if emacs is available... emacs: not found +No (so will not byte-compile emacs code) +Checking if sphinx is available and supports nroff output... python: not found +No (falling back to rst2man). +Checking if rst2man is available... Yes. +Checking which platform we are on... Unknown. + +*** Warning: Unknown platform. Notmuch might or might not build correctly. + +Checking byte order... 1234 +Checking for canonicalize_file_name... No (will use our own instead). +Checking for getline... Yes. +Checking for strcasestr... Yes. +Checking for strsep... Yes. +Checking for timegm... Yes. +Checking for dirent.d_type... Yes. +Checking for standard version of getpwuid_r... Yes. +Checking for standard version of asctime_r... Yes. +Checking for rpath support... Yes. +Checking for -Wl,--as-needed... Yes. +Checking for available C++ compiler warning flags... + -Wall -Wextra -Wwrite-strings +Checking for available C compiler warning flags... + -Wall -Wextra -Wwrite-strings -Wmissing-declarations + +so this particular issue seems to be fixed, right? + +I had some other issues with 0.18 though. + +1. pkgsrc's copy of rst2man is called "rst2man.py". The configure test +for this fails, of course, and there is another place where rst2man is +called directly. I've changed that to rst2man.py locally, but it'd be +good if configure could test for both names, set a variable to the one +found, and use the variable in the other place. + +2. doc/Makefile.local has "python" hardcoded. pkgsrc supports multiple +python versions at the same time, with the disadvantage that there is +no "python" executable, only "python2.6", "python2.7", "python3.3" +etc. I've passed in the proper executable name as PYTHONBIN and used +it in the Makefile. + +3. installation of notmuch-version.el fails, because the install rule +has no dependency on the generated file notmuch-version.el. I've added +such a dependency. + +The patches I used to make notmuch build are attached, but I can of +course test other patches if you prefer different solutions. I haven't +really run this version of notmuch yet. + +Cheers, + Thomas +--T4sUOijqQbZv57TR +Content-Type: text/plain; charset=us-ascii +Content-Disposition: attachment; filename="patch-doc_Makefile.local" + +$NetBSD$ + +--- doc/Makefile.local.orig 2014-05-06 07:27:29.000000000 +0000 ++++ doc/Makefile.local +@@ -7,8 +7,8 @@ SPHINXOPTS := -q + SPHINXBUILD = sphinx-build + DOCBUILDDIR := $(dir)/_build + +-prerst2man := python $(srcdir)/$(dir)/prerst2man.py +-mkdocdeps := python $(srcdir)/$(dir)/mkdocdeps.py ++prerst2man := ${PYTHONBIN} $(srcdir)/$(dir)/prerst2man.py ++mkdocdeps := ${PYTHONBIN} $(srcdir)/$(dir)/mkdocdeps.py + + # Internal variables. + ALLSPHINXOPTS := -d $(DOCBUILDDIR)/doctrees $(SPHINXOPTS) $(srcdir)/$(dir) + +--T4sUOijqQbZv57TR +Content-Type: text/plain; charset=us-ascii +Content-Disposition: attachment; filename="patch-doc_prerst2man.py" + +$NetBSD$ + +--- doc/prerst2man.py.orig 2014-05-06 07:27:29.000000000 +0000 ++++ doc/prerst2man.py +@@ -59,5 +59,5 @@ for page in man_pages: + outfile.write("".join(lines)) + outfile.close() + +- system('set -x; rst2man {0} {1}/{2}.{3}' ++ system('set -x; rst2man.py {0} {1}/{2}.{3}' + .format(filename, outdir, page[0], page[4])) + +--T4sUOijqQbZv57TR +Content-Type: text/plain; charset=us-ascii +Content-Disposition: attachment; filename="patch-emacs_Makefile.local" + +$NetBSD$ + +--- emacs/Makefile.local.orig 2014-05-06 07:27:29.000000000 +0000 ++++ emacs/Makefile.local +@@ -69,7 +69,7 @@ install: install-emacs + endif + + .PHONY: install-emacs +-install-emacs: ++install-emacs: $(dir)/notmuch-version.el + mkdir -p "$(DESTDIR)$(emacslispdir)" + install -m0644 $(emacs_sources) "$(DESTDIR)$(emacslispdir)" + ifeq ($(HAVE_EMACS),1) + +--T4sUOijqQbZv57TR +Content-Type: text/plain; charset=us-ascii +Content-Disposition: attachment; filename=patch-configure + +$NetBSD: patch-aa,v 1.1 2014/01/09 12:15:23 wiz Exp $ + +--- configure.orig 2014-05-06 07:27:29.000000000 +0000 ++++ configure +@@ -418,7 +418,7 @@ else + have_sphinx=0 + + printf "Checking if rst2man is available... " +- if rst2man -V > /dev/null 2>&1; then ++ if rst2man.py -V > /dev/null 2>&1; then + printf "Yes.\n" + have_rst2man=1 + else + +--T4sUOijqQbZv57TR--