From: David Bremner <david@tethera.net>
Date: Mon, 1 Jul 2013 03:07:53 +0000 (+2100)
Subject: Re: [PATCH v2 2/3] contrib: pick: remove hack notmuch-pick-show-match-message-with... 
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0c896622cd752131d5d5cef866acd1f9c04e54f1;p=notmuch-archives.git

Re: [PATCH v2 2/3] contrib: pick: remove hack notmuch-pick-show-match-message-with-wait
---

diff --git a/39/a08f218a86e60ec44aa2838e4a5e189ccc72fc b/39/a08f218a86e60ec44aa2838e4a5e189ccc72fc
new file mode 100644
index 000000000..853b1164e
--- /dev/null
+++ b/39/a08f218a86e60ec44aa2838e4a5e189ccc72fc
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 75919431FDB
+	for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 20:08:04 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Uqnnn7u7XxD1 for <notmuch@notmuchmail.org>;
+	Sun, 30 Jun 2013 20:07:58 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 53646431FDA
+	for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 20:07:58 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1UtUT7-0005H2-II; Mon, 01 Jul 2013 00:07:57 -0300
+Received: (nullmailer pid 5842 invoked by uid 1000); Mon, 01 Jul 2013
+	03:07:53 -0000
+From: David Bremner <david@tethera.net>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2 2/3] contrib: pick: remove hack
+	notmuch-pick-show-match-message-with-wait
+In-Reply-To: <87hagf5mi2.fsf@qmul.ac.uk>
+References: <1372582512-10777-1-git-send-email-markwalters1009@gmail.com>
+	<1372582512-10777-3-git-send-email-markwalters1009@gmail.com>
+	<87li5rtvbh.fsf@zancas.localnet> <87hagf5mi2.fsf@qmul.ac.uk>
+User-Agent: Notmuch/0.15.2+193~gb7df509 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Mon, 01 Jul 2013 00:07:53 -0300
+Message-ID: <877ghbt1ti.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 01 Jul 2013 03:08:04 -0000
+
+Mark Walters <markwalters1009@gmail.com> writes:
+
+> I am not sure what the best way to document the variable is: there are
+> several variables that are essentially buffer local versions of the
+> arguments passed to notmuch-pick. Should these duplicate the
+> documentation? Exactly the same situation occurs with notmuch-show in
+> notmuch-show.el and notmuch-search in notmuch.el and in both those cases
+> the functions are well documented but the variables are not documented.
+
+what about just saying something like "this variable is a buffer local
+copy of argument FOO to function BAR" ?
+
+d
+