From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 27 Feb 2009 09:03:21 +0000 (-0800)
Subject: Merge branch 'cc/maint-1.6.0-bisect-fix'
X-Git-Tag: v1.6.2~16
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0c3473561610ac9f94c65f64178d2a66ee73eb64;p=git.git

Merge branch 'cc/maint-1.6.0-bisect-fix'

* cc/maint-1.6.0-bisect-fix:
  bisect: fix quoting TRIED revs when "bad" commit is also "skip"ped

Conflicts:
	git-bisect.sh
---

0c3473561610ac9f94c65f64178d2a66ee73eb64
diff --cc git-bisect.sh
index 85db4ba40,f9a5c0bdf..a857db447
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@@ -290,31 -269,32 +290,32 @@@ filter_skipped() 
  
  	# Let's parse the output of:
  	# "git rev-list --bisect-vars --bisect-all ..."
- 	eval "$_eval" | while read hash line
- 	do
- 		case "$VARS,$FOUND,$TRIED,$hash" in
- 			# We display some vars.
- 			1,*,*,*) echo "$hash $line" ;;
- 
- 			# Split line.
- 			,*,*,---*) ;;
- 
- 			# We had nothing to search.
 -	eval_rev_list "$_eval" | {
++	eval "$_eval" | {
+ 		VARS= FOUND= TRIED=
+ 		while read hash line
+ 		do
+ 			case "$VARS,$FOUND,$TRIED,$hash" in
+ 			1,*,*,*)
+ 				# "bisect_foo=bar" read from rev-list output.
+ 				echo "$hash &&"
+ 				;;
+ 			,*,*,---*)
+ 				# Separator
+ 				;;
  			,,,bisect_rev*)
- 				echo "bisect_rev="
+ 				# We had nothing to search.
+ 				echo "bisect_rev= &&"
  				VARS=1
  				;;
- 
- 			# We did not find a good bisect rev.
- 			# This should happen only if the "bad"
- 			# commit is also a "skip" commit.
  			,,*,bisect_rev*)
- 				echo "bisect_rev=$TRIED"
+ 				# We did not find a good bisect rev.
+ 				# This should happen only if the "bad"
+ 				# commit is also a "skip" commit.
+ 				echo "bisect_rev='$TRIED' &&"
  				VARS=1
  				;;
- 
- 			# We are searching.
  			,,*,*)
+ 				# We are searching.
  				TRIED="${TRIED:+$TRIED|}$hash"
  				case "$_skip" in
  				*$hash*) ;;