From: Tomi Ollila Date: Tue, 7 Apr 2015 12:30:20 +0000 (+0300) Subject: Re: [PATCH] test: move nonexistant directory to something under notmuch's control. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0a9e39be6b7f4e169779aa237adf6f0dd76683ce;p=notmuch-archives.git Re: [PATCH] test: move nonexistant directory to something under notmuch's control. --- diff --git a/79/b0fcffe2dd23e9b8e9b0186dad3d189aff27ba b/79/b0fcffe2dd23e9b8e9b0186dad3d189aff27ba new file mode 100644 index 000000000..0b689ca24 --- /dev/null +++ b/79/b0fcffe2dd23e9b8e9b0186dad3d189aff27ba @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id E91EA6DE1992 + for ; Tue, 7 Apr 2015 05:30:52 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.179 +X-Spam-Level: * +X-Spam-Status: No, score=1.179 tagged_above=-999 required=5 tests=[AWL=0.527, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id kqDbAIRVdTgQ for ; + Tue, 7 Apr 2015 05:30:46 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 75ABC6DE198A + for ; Tue, 7 Apr 2015 05:30:46 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 7D11010019F; + Tue, 7 Apr 2015 15:30:20 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: move nonexistant directory to something under + notmuch's control. +In-Reply-To: <1428408900-22839-1-git-send-email-david@tethera.net> +References: <1428408900-22839-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.19+107~gab55bdb (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 07 Apr 2015 12:30:53 -0000 + +On Tue, Apr 07 2015, David Bremner wrote: + +> Apparently some systems actually have a directory called /nonexistent. +> It's hard to fathom a good reason for that, but oh well. As long as we +> don't create such a directory inside the notmuch source tree, the new +> version should be more robust. + +2 things + +although it makes this diff bigger should all /nonexistent... paths be +changed to ./nonexistent... -- it is a bit confusing having just this one +(or should there be another patch which converts rest of those) + +Is 'nonexistant' there for a reason (as dictionaries find definitions for +that) or is it misspelling of 'nonexistent'. If there is no reason I'd like +to see it written 'nonexistent' uniformly :D + + +Tomi + + +> --- +> This should (hopefully) fix the current failures on travis +> test/T560-lib-error.sh | 4 ++-- +> 1 file changed, 2 insertions(+), 2 deletions(-) +> +> diff --git a/test/T560-lib-error.sh b/test/T560-lib-error.sh +> index 828a44b..57abb28 100755 +> --- a/test/T560-lib-error.sh +> +++ b/test/T560-lib-error.sh +> @@ -43,13 +43,13 @@ int main (int argc, char** argv) +> { +> notmuch_database_t *db; +> notmuch_status_t stat; +> - stat = notmuch_database_open ("/nonexistent/foo", 0, 0); +> + stat = notmuch_database_open ("./nonexistent/foo", 0, 0); +> } +> EOF +> cat <<'EOF' >EXPECTED +> == stdout == +> == stderr == +> -Error opening database at /nonexistent/foo/.notmuch: No such file or directory +> +Error opening database at ./nonexistent/foo/.notmuch: No such file or directory +> EOF +> test_expect_equal_file EXPECTED OUTPUT +> +> -- +> 2.1.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch