From: David Bremner <david@tethera.net>
Date: Mon, 23 Nov 2015 12:46:04 +0000 (+2000)
Subject: Re: [PATCH] emacs: hello: fix accidental modification of widget-keymap
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0a81f4698b952995464690049b17114e6622349f;p=notmuch-archives.git

Re: [PATCH] emacs: hello: fix accidental modification of widget-keymap
---

diff --git a/3d/6e81004e15b2da7fc84e855fd75dc09c047a41 b/3d/6e81004e15b2da7fc84e855fd75dc09c047a41
new file mode 100644
index 000000000..5680a8e9b
--- /dev/null
+++ b/3d/6e81004e15b2da7fc84e855fd75dc09c047a41
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 6BAB66DE1378
+ for <notmuch@notmuchmail.org>; Mon, 23 Nov 2015 05:02:47 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.306
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.306 tagged_above=-999 required=5 tests=[AWL=0.245,
+  RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 5Pjg2cbkq0yS for <notmuch@notmuchmail.org>;
+ Mon, 23 Nov 2015 05:02:42 -0800 (PST)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 6829E6DE0943
+ for <notmuch@notmuchmail.org>; Mon, 23 Nov 2015 05:02:42 -0800 (PST)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1a0qVR-0000QR-4P; Mon, 23 Nov 2015 07:46:05 -0500
+Received: (nullmailer pid 30174 invoked by uid 1000);
+ Mon, 23 Nov 2015 12:46:04 -0000
+From: David Bremner <david@tethera.net>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] emacs: hello: fix accidental modification of
+ widget-keymap
+In-Reply-To: <1447326139-13620-1-git-send-email-markwalters1009@gmail.com>
+References: <1447326139-13620-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Mon, 23 Nov 2015 08:46:04 -0400
+Message-ID: <87twoc51f7.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 23 Nov 2015 13:02:47 -0000
+
+Mark Walters <markwalters1009@gmail.com> writes:
+
+> In emacs24 we use make-composed-keymap. It seems that if only a single
+> map is specified then emacs just resuses it rather than creating a
+> copy of it. Thus use make-sparse-keymap to force a copy.
+> ---
+>
+> pseudomyne and the diredful author thamer found that we modify
+> widget-keymap in notmuch. We clearly don't want to, and I think we
+> tried not to, but emacs was being clever and reused the old keymap
+> rather than creating a new one.
+
+applied to release and master.
+
+d