From: Jason Miller Date: Tue, 23 Jul 2013 00:33:03 +0000 (+1700) Subject: Unquoted message ID in notmuch-mutt-tag X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=09d5d31af25c4872b6e7aee2a65838daad797a74;p=notmuch-archives.git Unquoted message ID in notmuch-mutt-tag --- diff --git a/46/7baab8fd62b9202e9a2f91611467b35c11c33d b/46/7baab8fd62b9202e9a2f91611467b35c11c33d new file mode 100644 index 000000000..3caf2c00c --- /dev/null +++ b/46/7baab8fd62b9202e9a2f91611467b35c11c33d @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 164E5431FBC + for ; Mon, 22 Jul 2013 17:52:29 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nRdZh2hM1dKJ for ; + Mon, 22 Jul 2013 17:52:21 -0700 (PDT) +X-Greylist: delayed 1155 seconds by postgrey-1.32 at olra; + Mon, 22 Jul 2013 17:52:20 PDT +Received: from fed1rmfepi208.cox.net (fed1rmfepi208.cox.net [68.230.241.153]) + by olra.theworths.org (Postfix) with ESMTP id C43A1431FB6 + for ; Mon, 22 Jul 2013 17:52:20 -0700 (PDT) +Received: from fed1rmimpo305 ([68.230.241.173]) by fed1rmfepo203.cox.net + (InterMail vM.8.01.05.09 201-2260-151-124-20120717) with ESMTP + id <20130723003304.BWSP3846.fed1rmfepo203.cox.net@fed1rmimpo305> + for ; Mon, 22 Jul 2013 20:33:04 -0400 +Received: from localhost ([70.191.80.19]) by fed1rmimpo305 with cox + id 3cZ31m00J0R0GNW01cZ3bs; Mon, 22 Jul 2013 20:33:03 -0400 +X-CT-Class: Clean +X-CT-Score: 0.00 +X-CT-RefID: str=0001.0A020207.51EDCF3F.012C,ss=1,re=0.000,fgs=0 +X-CT-Spam: 0 +X-Authority-Analysis: v=2.0 cv=R/Dd76tX c=1 sm=1 + a=8Pu+u8o12PWZCfupdeghHQ==:17 a=wom5GMh1gUkA:10 a=wOsrnI10qBsA:10 + a=as2ii8JTC2oA:10 a=kj9zAlcOel0A:10 a=BswL-RFwAAAA:8 a=kM_2MJY8AAAA:8 + a=-DOwLxJbGmkA:10 a=Am0YYMluCUEbXP6Kt-EA:9 a=CjuIK1q_8ugA:10 + a=bqnDBv3PJxgA:10 a=NI3GwEGIxhIA:10 a=8Pu+u8o12PWZCfupdeghHQ==:117 +X-CM-Score: 0.00 +Authentication-Results: cox.net; auth=pass (CRAM-MD5) + smtp.auth=aidenn01@cox.net +Date: Mon, 22 Jul 2013 17:33:03 -0700 +From: Jason Miller +To: notmuch@notmuchmail.org +Subject: Unquoted message ID in notmuch-mutt-tag +Message-ID: <20130723003303.GA21463@home.jasonmmiller.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Mailman-Approved-At: Tue, 30 Jul 2013 02:14:53 -0700 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 23 Jul 2013 00:52:29 -0000 + +Hi, + +Just started using notmuch along with notmuch-mutt. I found a bug in +notmuch-mutt where the message id is not shell-quoted in the tag_action. +a simple one-line-fix is to shell-quote the result of get_message_id: + +@@ -150,7 +150,7 @@ + } + + sub tag_action(@) { +- my $mid = get_message_id(); ++ my $mid = shell_quote(get_message_id()); + + system("notmuch tag " + . shell_quote(join(' ', @_)) + +-Jason