From: Felipe Contreras Date: Tue, 2 Apr 2013 19:46:25 +0000 (+1800) Subject: RE: [PATCH 5/5] Drop harmful reply buffer preparation X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=09350cd4f4eb2108f8cc4b178bfb32ff0b7c612f;p=notmuch-archives.git RE: [PATCH 5/5] Drop harmful reply buffer preparation --- diff --git a/64/58d969077a53a3b32c5efd86ba17c860cea8f7 b/64/58d969077a53a3b32c5efd86ba17c860cea8f7 new file mode 100644 index 000000000..d3babcc53 --- /dev/null +++ b/64/58d969077a53a3b32c5efd86ba17c860cea8f7 @@ -0,0 +1,115 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7A069431FAF + for ; Tue, 2 Apr 2013 12:53:00 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id M0mwgzWC5fpl for ; + Tue, 2 Apr 2013 12:53:00 -0700 (PDT) +Received: from mail-ye0-f177.google.com (mail-ye0-f177.google.com + [209.85.213.177]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E7ABD431FAE + for ; Tue, 2 Apr 2013 12:52:59 -0700 (PDT) +Received: by mail-ye0-f177.google.com with SMTP id l14so123368yen.22 + for ; Tue, 02 Apr 2013 12:52:59 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=x-received:date:from:to:cc:message-id:in-reply-to:references + :subject:mime-version:content-type:content-transfer-encoding; + bh=TEpx7c5/V04LuuhQCRorljhZxRivZtV/9s4zObmHDkA=; + b=pO6BqYpsGbIydnjEz+lOpBd04T1aKEE32F1/D9VUXEJN6Uzuli1IP7EV678pp+qIm1 + re9va5CGC1UtfxV6gGmLSWe5vi34V3WbH8DIb4AywZh9iBuHTEGxXopb2MnBB0cskLQu + Mr2E2XP8aXzbufW4qzjLWsQZiYf89gxLHp7EUgygh9cqdxWO3fTtWXxqNexcA9x6EyrP + yRASU1uzv6WTM3AZNwS8TIIZ/J+AQKJ8wRB+N77stckeekDl9Q0SztHNtp2lRJs4oQp8 + bcy03vlMgE9is779iaAp5nZiG4zDYILGBpkdpNh9lEQezps62UI1SEM4fws5u1crk/vG + E5MQ== +X-Received: by 10.236.16.202 with SMTP id h50mr16621895yhh.39.1364932379469; + Tue, 02 Apr 2013 12:52:59 -0700 (PDT) +Received: from localhost (187-163-100-70.static.axtel.net. [187.163.100.70]) + by mx.google.com with ESMTPS id w69sm5170223yhe.4.2013.04.02.12.52.57 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Tue, 02 Apr 2013 12:52:58 -0700 (PDT) +Date: Tue, 02 Apr 2013 13:46:25 -0600 +From: Felipe Contreras +To: "Kirill A. Shutemov" , + Felipe Contreras +Message-ID: <515b359189b29_146e1045e1093948@nysa.mail> +In-Reply-To: <1359388340-27136-6-git-send-email-kirill@shutemov.name> +References: <1359388340-27136-1-git-send-email-kirill@shutemov.name> + <1359388340-27136-6-git-send-email-kirill@shutemov.name> +Subject: RE: [PATCH 5/5] Drop harmful reply buffer preparation +Mime-Version: 1.0 +Content-Type: text/plain; + charset=utf-8 +Content-Transfer-Encoding: 7bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 02 Apr 2013 19:53:00 -0000 + +Kirill A. Shutemov wrote: +> From: "Kirill A. Shutemov" +> +> Inserting empty lines at the end of reply buffer and switching to insert +> mode are not what user want on reply. It's only annoying if you try to +> comment on patch. +> +> If a user really wants this kind of preparation it should be implemented +> as an user-specific hook. + +Insert mode, maybe, but the empty lines don't hurt. See, with your patch I end up in: + +> part = orig.find_first_text +> part.convert.each_line do |l| +> body_lines << "> %s" % l.chomp +> -- +> 1.7.10.4 <- HERE +> +> -- + +I cannot type there, and in any case I have to remove those lines, so I end +selecting the text upwards and remove them. + +With the current code: + +> part = orig.find_first_text +> part.convert.each_line do |l| +> body_lines << "> %s" % l.chomp +> -- +> 1.7.10.4 +> +> <- HERE +> +> -- + +Not much of a difference, I still have to select the lines upwards and remove them. + +That is of course if you reply *inline*. You might want to reply to the whole +thing without modifications, in which case the original behavior is more +useful. + +I'm not strongly opposed to this, but I don't see why those extra lines would hurt. + +Cheers. + +-- +Felipe Contreras