From: Mark Walters Date: Mon, 9 Nov 2015 14:59:58 +0000 (+0000) Subject: Re: [PATCH] emacs: Fontify From with message-header-other X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=08cf80ae48ac3735a34f51576257446dab4f2451;p=notmuch-archives.git Re: [PATCH] emacs: Fontify From with message-header-other --- diff --git a/2d/0de2fce817f8be53744ef1f6a085353ef257ef b/2d/0de2fce817f8be53744ef1f6a085353ef257ef new file mode 100644 index 000000000..8eb23334c --- /dev/null +++ b/2d/0de2fce817f8be53744ef1f6a085353ef257ef @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id E33F06DE1B0A + for ; Mon, 9 Nov 2015 07:00:04 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.182 +X-Spam-Level: +X-Spam-Status: No, score=0.182 tagged_above=-999 required=5 tests=[AWL=0.052, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id C63UkeICpfRv for ; + Mon, 9 Nov 2015 07:00:02 -0800 (PST) +Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com + [74.125.82.49]) by arlo.cworth.org (Postfix) with ESMTPS id 329BC6DE1B00 for + ; Mon, 9 Nov 2015 07:00:02 -0800 (PST) +Received: by wmec201 with SMTP id c201so73717825wme.1 + for ; Mon, 09 Nov 2015 07:00:00 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=c7oFYDevgvvfO9xmiF6a92GfvlVHq1eowN+lB4Bfnc0=; + b=tk0Luac7Zn4Pz7DpUEULF1AEZap88ySc6ha7XSg6/7enTURR8v3LVv1WZhGwJkTK++ + pdxGe/zFXxsf8kH6e2YjOxfpHcID7QxOi5NH990rDk5xVWKl2Yh/ePtOB3HLPVYUq2a7 + j0R2VGHqqLrSiSpIBIQiVW/1BGm0A/x50r7pmTiDJ7BBJjmxbbSYy242wSfx7kr2kRBN + w4RfxhwyrwWnDapquYFfmCkKdsKAxEDaluZumh5RooBm7tstmdSCnwsE8Fo2x4XBF5mb + +mWycmB+U7TLSgGM52VL7WMiWGTMzbzMpeGWGLlTbzSFT4EzYq+ba/VNMsr0z7mOBVRh + mnag== +X-Received: by 10.194.104.132 with SMTP id ge4mr29547319wjb.127.1447081200724; + Mon, 09 Nov 2015 07:00:00 -0800 (PST) +Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) + by smtp.gmail.com with ESMTPSA id j4sm14729830wmg.18.2015.11.09.06.59.59 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 09 Nov 2015 07:00:00 -0800 (PST) +From: Mark Walters +To: "H. J. Illikainen" , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Fontify From with message-header-other +In-Reply-To: <1446677040-43496-1-git-send-email-hji@dyntopia.com> +References: <1446677040-43496-1-git-send-email-hji@dyntopia.com> +User-Agent: Notmuch/0.18+519~ga09e253 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Mon, 09 Nov 2015 14:59:58 +0000 +Message-ID: <87vb9b6wwh.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 09 Nov 2015 15:00:05 -0000 + + +This looks good to me (and all tests pass) so +1. + +Best wishes + +Mark + +On Wed, 04 Nov 2015, "H. J. Illikainen" wrote: + +> Commit e26d767897e8ab59f05808a12ac5c9c1e3c7030f changed the +> fontification of the body associated with the From header to +> message-header-from. However, that face is non-existent, and in +> message.el (message-font-lock-keywords) the From-header falls through +> and is attributed the message-header-other face. +> +> This commit removes the fontification of the [Ff]rom header in +> notmuch-show-mode in order to fontify it using the message-header-other +> face. +> +> This only affects non-default configurations where +> notmuch-message-headers is set to display From. +> --- +> emacs/notmuch-show.el | 2 -- +> 1 file changed, 2 deletions(-) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 49fd198..793f1a5 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -353,8 +353,6 @@ operation on the contents of the current buffer." +> 'message-header-cc) +> ((looking-at "[Ss]ubject:") +> 'message-header-subject) +> - ((looking-at "[Ff]rom:") +> - 'message-header-from) +> (t +> 'message-header-other)))) +> +> -- +> H. J. Illikainen +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> https://notmuchmail.org/mailman/listinfo/notmuch