From: Tomi Ollila Date: Sun, 14 Feb 2016 19:45:45 +0000 (+0200) Subject: Re: [PATCH v5 0/7] emacs: Improve the cited message included in replies X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=08b5be2937288611cf46829e8e80ccecb4318160;p=notmuch-archives.git Re: [PATCH v5 0/7] emacs: Improve the cited message included in replies --- diff --git a/dc/f31fd0e7476191906e9aced6a6a8523ced2420 b/dc/f31fd0e7476191906e9aced6a6a8523ced2420 new file mode 100644 index 000000000..e855be828 --- /dev/null +++ b/dc/f31fd0e7476191906e9aced6a6a8523ced2420 @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 34EC96DE1AC4 + for ; Sun, 14 Feb 2016 11:45:46 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.638 +X-Spam-Level: +X-Spam-Status: No, score=0.638 tagged_above=-999 required=5 tests=[AWL=-0.014, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3BekBPRYj5mB for ; + Sun, 14 Feb 2016 11:45:42 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 55E856DE1ABD + for ; Sun, 14 Feb 2016 11:45:41 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id B5AD71000CA; + Sun, 14 Feb 2016 21:45:45 +0200 (EET) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v5 0/7] emacs: Improve the cited message included in + replies +In-Reply-To: <1455475199-32622-1-git-send-email-markwalters1009@gmail.com> +References: <1455475199-32622-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.21+70~g0bc8909 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 14 Feb 2016 19:45:46 -0000 + +On Sun, Feb 14 2016, Mark Walters wrote: + +> This is a slight update and a rebase of this patch set (previous +> version at +> id:1446894276-7814-1-git-send-email-markwalters1009@gmail.com ) +> +> The only change from last time (apart from fixing rebasing to master) +> is the rewording of couple of minor comments inline with dme's review +> of the previous version. +> +> Although I am submitting it is primarily dme's series, with minor +> updates from me. +> +> One particular motivation for this series is that it fixes a long +> standing bug we have that replying to a message with an rfc822 part +> completely omits that part. It also fixes the bug whereby we don't +> include application/octet-stream parts which are actually text/plain +> (and thus are displayed in show mode). +> +> This series makes the reply code use the same code as the show code so +> everything works as expected: the reply buffer looks essentially the +> same as the show buffer. +> +> There is one slight difference: the user might want different part +> headers displayed when replying; both because the audience is +> different (a non-notmuch using recipient) and because the buttons +> don't "work" (you can't click on them to show or view a part). +> +> Dme and I disagree on which of these we would like to see so make that +> customisable. + +Does *NOT* look bad, works and (relevant) tests pass. + +We'd need at least David to verify that Mark got his (David's that is) +patches properly rebased... + +Tomi + +> +> The key change is patch 3 which switches how reply works. Also note +> that patch 2 is almost all whitespace change as the changes modify the +> indentation. +> +> Best wishes +> +> Mark +> +> +> David Edmondson (6): +> emacs/show: Re-arrange determination if a part header is necessary +> emacs/show: Accommodate the lack of part header buttons +> emacs/mua: Generate improved cited text for replies +> emacs/show: Remove the 'no-buttons option of +> `notmuch-show-insert-bodypart' +> emacs/show: Make the insertion of part headers overridable. +> emacs/mua: Let user specify which parts get a header in citations. +> +> Mark Walters (1): +> test: fix the tests for the new reply code +> +> emacs/notmuch-mua.el | 60 ++++++++++----------- +> emacs/notmuch-show.el | 144 +++++++++++++++++++++++++++++++------------------- +> test/T310-emacs.sh | 32 +++++++++++ +> test/test-lib.el | 4 ++ +> 4 files changed, 156 insertions(+), 84 deletions(-) +> +> -- +> 2.1.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> https://notmuchmail.org/mailman/listinfo/notmuch