From: Daniel Kahn Gillmor Date: Tue, 10 Sep 2013 19:31:48 +0000 (+2000) Subject: Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init() X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=083050c42e683666c53944c4d6928c0f3b37db89;p=notmuch-archives.git Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init() --- diff --git a/b1/ad07bd5c1705efdb34a4487fe2b8a688f48495 b/b1/ad07bd5c1705efdb34a4487fe2b8a688f48495 new file mode 100644 index 000000000..3e6e0b8c9 --- /dev/null +++ b/b1/ad07bd5c1705efdb34a4487fe2b8a688f48495 @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B0EBE431FAF + for ; Tue, 10 Sep 2013 12:31:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id kFF2OoOmZ2kl for ; + Tue, 10 Sep 2013 12:31:54 -0700 (PDT) +Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108]) + by olra.theworths.org (Postfix) with ESMTP id 40A5F431FAE + for ; Tue, 10 Sep 2013 12:31:54 -0700 (PDT) +Received: from [192.168.13.193] (lair.fifthhorseman.net [108.58.6.98]) + by che.mayfirst.org (Postfix) with ESMTPSA id 6C856F983 + for ; Tue, 10 Sep 2013 15:31:49 -0400 (EDT) +Message-ID: <522F73A4.90802@fifthhorseman.net> +Date: Tue, 10 Sep 2013 15:31:48 -0400 +From: Daniel Kahn Gillmor +User-Agent: Mozilla/5.0 (X11; Linux x86_64; + rv:17.0) Gecko/20130821 Icedove/17.0.8 +MIME-Version: 1.0 +To: notmuch +Subject: Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to + g_mime_init() +References: <1378839078-6298-1-git-send-email-jani@nikula.org> +In-Reply-To: <1378839078-6298-1-git-send-email-jani@nikula.org> +X-Enigmail-Version: 1.5.1 +Content-Type: multipart/signed; micalg=pgp-sha512; + protocol="application/pgp-signature"; + boundary="----enig2WPDKSBUBLPAXTSGANNNH" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 10 Sep 2013 19:31:59 -0000 + +This is an OpenPGP/MIME signed message (RFC 4880 and 3156) +------enig2WPDKSBUBLPAXTSGANNNH +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable + +On 09/10/2013 02:51 PM, Jani Nikula wrote: +> As explained by Jeffrey Stedfast, the author of GMime, quoted in [1]: +>=20 +>> Passing the GMIME_ENABLE_RFC2047_WORKAROUNDS flag to g_mime_init() +>> *should* solve the decoding problem mentioned in the thread. This +>> flag should be safe to pass into g_mime_init() without any bad side +>> effects and my unit tests do test that code-path. + +the result of doing this is that there will become legitimately-crafted +subject lines that are now unrepresentable. + +I'm always leery of trying to improve support for data that doesn't +follow the standards at the expense of data that *does* follow the +standards. + + --dkg + + +------enig2WPDKSBUBLPAXTSGANNNH +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature +Content-Disposition: attachment; filename="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.14 (GNU/Linux) +Comment: Using GnuPG with Icedove - http://www.enigmail.net/ + +iQJ8BAEBCgBmBQJSL3OkXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w +ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFQjk2OTEyODdBN0FEREUzNzU3RDkxMUVB +NTI0MDFCMTFCRkRGQTVDAAoJEKUkAbEb/fpcVh0QAJVRFs2iLFsBM4ESUZe+MGG1 +n+Co0xw3ykZoCuvDt9acbcBhxy6jyKX1xJtNBR1nhylO/dE/mmp+SyWlmmMiYtu8 +D2/3YA3mhZblGJIsmxaNZZ9U5JYlutrwrERaa8Hg/5zWoGbDt7bdnYynGjR9aWgr +TTB+dq+s1H8ydxFyrJlCmSp/tmBa20lUk/CoyK4oHHvpUWtHnKJu2IrsjkC94Irq +XlRgNORzZb2tPXb8iK3NuZUjHkC3lukbqrhJvi7pVCJ8K6ZQ8sxCD6m0GGqhEb/r +WNy0G+Q7xiudye4twCcf8QfNY4KdDTPLbEtKlXkrXl6a1QlVQAJ/EkRzvjWwk/wv +KPm1A59DF+wlH6mqhFSZaOLrIMnnexUzPAwcrsJNsdUtF8lYJZhAaWyk0Or7TBKG +D2xXh7UstURkhsD4kOzV7dysVd3/eogXTSubycJRGyVsLu/RM3yApJZ3LS7us1qY +0yrnvG5XK1KJEonBYhFufbaStq0GNJEGGpvguw0YsmFHtVz01hEQYIRfZHOacZjA +6a490yixSwO/2Hqe9WKSVdUu6PZijY6r+sOf7/zlbP9s3CIGZfcewvJ94JjA6nTt +tvcsA6e0CFf+D8c8IGTFeV1HiYuUZpZxldsNLoNCwXJFkuoMuTwH6Y4Uyp8sOuu3 +bnRHzinaMLRnYbrFibC5 +=J/8a +-----END PGP SIGNATURE----- + +------enig2WPDKSBUBLPAXTSGANNNH--