From: Daniel Kahn Gillmor Date: Sun, 24 Jan 2016 15:55:12 +0000 (+1900) Subject: Re: [PATCH v2 04/16] Provide _notmuch_crypto_{set,get}_gpg_path X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=074bec88d33aee9bbcaf9e07d593785907e9be25;p=notmuch-archives.git Re: [PATCH v2 04/16] Provide _notmuch_crypto_{set,get}_gpg_path --- diff --git a/17/32c123827fb82d12f6df7b11544b5e9dbd5927 b/17/32c123827fb82d12f6df7b11544b5e9dbd5927 new file mode 100644 index 000000000..22edae925 --- /dev/null +++ b/17/32c123827fb82d12f6df7b11544b5e9dbd5927 @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 8C4C96DE13DB + for ; Sun, 24 Jan 2016 07:55:28 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.182 +X-Spam-Level: +X-Spam-Status: No, score=-0.182 tagged_above=-999 required=5 + tests=[AWL=-0.182] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id sXzJCgOOOBkg for ; + Sun, 24 Jan 2016 07:55:26 -0800 (PST) +Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108]) + by arlo.cworth.org (Postfix) with ESMTP id B7E176DE13E3 + for ; Sun, 24 Jan 2016 07:55:17 -0800 (PST) +Received: from fifthhorseman.net (h-67-101-29-155.nycm.ny.dynamic.megapath.net + [67.101.29.155]) + by che.mayfirst.org (Postfix) with ESMTPSA id 5F9D9F991; + Sun, 24 Jan 2016 10:55:11 -0500 (EST) +Received: by fifthhorseman.net (Postfix, from userid 1000) + id B0CF420085; Sun, 24 Jan 2016 10:55:12 -0500 (EST) +From: Daniel Kahn Gillmor +To: Tomi Ollila , Notmuch Mail +Subject: Re: [PATCH v2 04/16] Provide _notmuch_crypto_{set,get}_gpg_path +In-Reply-To: +References: <1453258369-7366-1-git-send-email-dkg@fifthhorseman.net> + <1453258369-7366-5-git-send-email-dkg@fifthhorseman.net> + +User-Agent: Notmuch/0.21+67~g41ad7ff (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sun, 24 Jan 2016 10:55:12 -0500 +Message-ID: <87a8nv7z1b.fsf@alice.fifthhorseman.net> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 24 Jan 2016 15:55:28 -0000 + +Thanks for the review, Tomi! + +On Sun 2016-01-24 10:23:02 -0500, Tomi Ollila wrote: +> On Wed, Jan 20 2016, Daniel Kahn Gillmor wrote: +> +>> Use functions to access the gpg_path for a _notmuch_crypto_t object. +>> This lets us return sensible defaults based on the state of the user's +>> machine. +>> --- +>> notmuch-reply.c | 13 ++++++++++--- +>> notmuch-show.c | 12 ++++++++++-- +>> util/crypto.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++++- +>> util/crypto.h | 8 +++++++- +>> 4 files changed, 75 insertions(+), 7 deletions(-) +>> +>> diff --git a/util/crypto.c b/util/crypto.c +>> index c18c82c..0b51347 100644 +>> --- a/util/crypto.c +>> +++ b/util/crypto.c +>> @@ -21,7 +21,11 @@ +>> +>> #include "notmuch.h" +>> #include "crypto.h" +>> +#include "search-path.h" +>> #include +>> +#include +>> + +>> +#define ARRAY_SIZE(arr) (sizeof (arr) / sizeof (arr[0])) +>> +>> #define ARRAY_SIZE(arr) (sizeof (arr) / sizeof (arr[0])) +> +> duplicate ARRAY_SIZE definition ? + +whoops, thanks for catching that. I think that got inserted from a git +rebase. fixing in my local copy now. + + --dkg