From: Nate Eagleson Date: Thu, 2 Jul 2015 12:05:10 +0000 (+2000) Subject: Re: [PATCH] build: Support Mac OS X 10.6.8 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=05de5fa4ab2f96d68702ef3b97310dabede23d07;p=notmuch-archives.git Re: [PATCH] build: Support Mac OS X 10.6.8 --- diff --git a/18/94f80b02b1f324462875e7d12b23eae5cf8cab b/18/94f80b02b1f324462875e7d12b23eae5cf8cab new file mode 100644 index 000000000..5a2760562 --- /dev/null +++ b/18/94f80b02b1f324462875e7d12b23eae5cf8cab @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id EA1906DE09FB + for ; Thu, 2 Jul 2015 05:05:26 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.475 +X-Spam-Level: +X-Spam-Status: No, score=-0.475 tagged_above=-999 required=5 tests=[AWL=0.225, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, + SPF_PASS=-0.001, T_FREEMAIL_FORGED_FROMDOMAIN=0.01, + T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4XyWHaSa27cJ for ; + Thu, 2 Jul 2015 05:05:20 -0700 (PDT) +Received: from mail-qk0-f170.google.com (mail-qk0-f170.google.com + [209.85.220.170]) + by arlo.cworth.org (Postfix) with ESMTPS id 2E8846DE0924 + for ; Thu, 2 Jul 2015 05:05:20 -0700 (PDT) +Received: by qkbp125 with SMTP id p125so49769827qkb.2 + for ; Thu, 02 Jul 2015 05:05:18 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=sender:from:to:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=JqxKASSMQz84ORse5uS59lrTsPQZ5Zr4VpTlaxYqpWQ=; + b=qn7BRSvKW0qmX53tZRnxC/fBFyAQ25luWA9MTXazUYqELjAVt+5AEocG2YflMPTunN + By9aCyPvyUhV1QCH2fqbzd13jcINtfvgsh1jMjppUcKMoP85AiWPekkU4VhwrQnhkb70 + AGvLh+scLdIVIR0nF5LVpF8idxrOMQ1UHhW/2b2ed69Xi3fAtG4apo7+f4mx3aZaqq4D + zvXg5zJgdejbsNQ9t/UbkmUJz+2XGr7JPvFkl5AgWtlL0ejQDIWmWFS8RGMjwQtU0a4N + ONCASdBWvry/VQP6z8fsQj3pm6gzz0LHl2T5VW+mJpU3cYO3hwVmAz/VlQk5k+jMPG9V + qDGQ== +X-Received: by 10.55.23.149 with SMTP id 21mr63324251qkx.67.1435838718616; + Thu, 02 Jul 2015 05:05:18 -0700 (PDT) +Received: from Aymairn.local ([70.42.157.61]) + by mx.google.com with ESMTPSA id 41sm2607872qgf.47.2015.07.02.05.05.15 + (version=TLSv1 cipher=RC4-SHA bits=128/128); + Thu, 02 Jul 2015 05:05:16 -0700 (PDT) +Sender: Nathan Eagleson +From: Nate Eagleson +To: "J. Lewis Muir" , notmuch@notmuchmail.org +Subject: Re: [PATCH] build: Support Mac OS X 10.6.8 +In-Reply-To: <55940744.7050100@imca-cat.org> +References: <1435699747-13591-1-git-send-email-nate@nateeag.com> + <1435699747-13591-2-git-send-email-nate@nateeag.com> + <55940744.7050100@imca-cat.org> +User-Agent: Notmuch/0.20.1+25~g0ab9a1a (http://notmuchmail.org) Emacs/24.4.1 + (i686-apple-darwin) +Date: Thu, 02 Jul 2015 08:05:10 -0400 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 02 Jul 2015 12:05:27 -0000 + +"J. Lewis Muir" writes: + +> On 6/30/15 4:29 PM, Nate Eagleson wrote: +>> +# Mac OS X 10.6 has a built-in libutil.dylib that prevents ld from +>> +# picking up notmuch's libutil.a. The best way to prefer our local +>> +# libutil.a is to specify it via absolute path, which should work on +>> +# all supported OSes. +>> +LIBUTIL_PATH=${srcdir}/util/libutil.a +> +> Hi, Nate. +> +> I think it would be better to make the above comment not specific to OS +> X, but instead just refer to "systems that have a built-in util library" +> or similar. For example, NetBSD has a built-in util library [1]. I +> don't have access to a FreeBSD system, but it looks like FreeBSD might +> have a built-in util library too [2]. +> +> Similarly for the one-line commit summary since this change is not +> specific to OS X. +> +> Regards, +> +> Lewis +> +> [1] http://netbsd.gw.com/cgi-bin/man-cgi?libutil++NetBSD-current +> [2] http://svnweb.freebsd.org/base/head/lib/libutil/Makefile?view=markup + +Good point. I'll update that. + +-Nate