From: David Bremner <david@tethera.net>
Date: Sun, 3 Mar 2013 16:23:50 +0000 (+2000)
Subject: Re: [PATCH 3/6] cli: abstract subcommand finding into a new function
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=05c3db06d8a48020b94609099edc2eddb6f89c57;p=notmuch-archives.git

Re: [PATCH 3/6] cli: abstract subcommand finding into a new function
---

diff --git a/10/40e067d3ae34dbffa9fa7e44320901265a3d0c b/10/40e067d3ae34dbffa9fa7e44320901265a3d0c
new file mode 100644
index 000000000..5fa1527e5
--- /dev/null
+++ b/10/40e067d3ae34dbffa9fa7e44320901265a3d0c
@@ -0,0 +1,70 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 10BC1431FAF
+	for <notmuch@notmuchmail.org>; Sun,  3 Mar 2013 08:23:58 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 74WoPdw4fq2g for <notmuch@notmuchmail.org>;
+	Sun,  3 Mar 2013 08:23:57 -0800 (PST)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 8934C431FAE
+	for <notmuch@notmuchmail.org>; Sun,  3 Mar 2013 08:23:57 -0800 (PST)
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.82.78] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa
+	(TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1UCBhb-0000Xe-PP; Sun, 03 Mar 2013 12:23:56 -0400
+Received: from bremner by zancas.localnet with local (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1UCBhW-0001Mc-6j; Sun, 03 Mar 2013 12:23:50 -0400
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 3/6] cli: abstract subcommand finding into a new function
+In-Reply-To:
+ <4fa07d936647d316f642c8f30b763d316604ea5f.1359495450.git.jani@nikula.org>
+References: <cover.1359495450.git.jani@nikula.org>
+	<4fa07d936647d316f642c8f30b763d316604ea5f.1359495450.git.jani@nikula.org>
+User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-pc-linux-gnu)
+Date: Sun, 03 Mar 2013 12:23:50 -0400
+Message-ID: <871ubwzc2x.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-Spam_bar: -
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 03 Mar 2013 16:23:58 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+> Clean up code.
+> ---
+>  notmuch.c |   68 +++++++++++++++++++++++++++++++------------------------------
+>  1 file changed, 35 insertions(+), 33 deletions(-)
+
+This looks OK, and independent from the other patches in the series, but
+it will need to be rebased for changes in calling talloc_report
+(d0370409)
+
+d