From: Mark Walters Date: Sun, 26 May 2013 06:50:06 +0000 (+0100) Subject: [PATCH 0/2] Contrib: Pick: Remove horrible hack X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=05876d4e28cf8d7bab69a06fa5fa157aa0cb53a5;p=notmuch-archives.git [PATCH 0/2] Contrib: Pick: Remove horrible hack --- diff --git a/7a/c739e1ecd843759cc7cca8b40bcc61ae37c6bd b/7a/c739e1ecd843759cc7cca8b40bcc61ae37c6bd new file mode 100644 index 000000000..634786707 --- /dev/null +++ b/7a/c739e1ecd843759cc7cca8b40bcc61ae37c6bd @@ -0,0 +1,91 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 53212431FBF + for ; Sat, 25 May 2013 23:50:20 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 7izKtTl9qbdp for ; + Sat, 25 May 2013 23:50:14 -0700 (PDT) +Received: from mail-we0-f171.google.com (mail-we0-f171.google.com + [74.125.82.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9EF6E431FAE + for ; Sat, 25 May 2013 23:50:14 -0700 (PDT) +Received: by mail-we0-f171.google.com with SMTP id t59so3671755wes.16 + for ; Sat, 25 May 2013 23:50:13 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer; + bh=R7gArVe6SYTA3mA08Y1quga6oexXI6O9vZoJqa596H4=; + b=DpR98oenVrVSx3ElF56UYEYWDnt4FrYlDUmbaTJWyMC5kk7hq45bxWxSCnyqd9LBBw + A4+YyrzpOHFOiUH+dFoE0OGm0niR+HZE5fpdocVNm9+aamAuzGt/zndPKCkbBtxUS9X7 + mV522zOf6YqvxkaP7QzKIKXEARoPyPzml7vAWVML/eoTR7WAwf/MXwOtbzjlW0hY8g3Z + nEye49YvfYRzDgzk5Zi3TcbZsWTPUlSa/nJKx8iMGWAyhhovyjNx3pmMEZZ9vLXAloUG + vSwZd80jF1GhpCtngtCkNfFFAphRSuHq4ZDdzgcdvm6u5TAJfgq2Zw7yBqX9K+zTxfEu + Ridw== +X-Received: by 10.180.14.199 with SMTP id r7mr4061337wic.6.1369551013585; + Sat, 25 May 2013 23:50:13 -0700 (PDT) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id fz8sm9115445wib.2.2013.05.25.23.50.12 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sat, 25 May 2013 23:50:13 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/2] Contrib: Pick: Remove horrible hack +Date: Sun, 26 May 2013 07:50:06 +0100 +Message-Id: <1369551008-30697-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 26 May 2013 06:50:20 -0000 + +Pick used to have one horrible hack: if the user asked it to open the +first matching message it had to check whether that had arrived (as +the search is asynchronous) and if not wait and try again. Now the +opening of the first matching message is called via the pick process +filter this hack can be removed. + +This did reveal the followibg small bug. Pick shows the subject line +in the output but if it is the same as the previous line (ignoring re: +etc) it shows ... If a single message is refreshed (eg for a tag +update) this was got wrong. The change above triggered this and made +the test fail as the unread tag was removed from the first matching +message when it was displayed. + +Patch 2/2 fixes this by storing the previous subject with the search result. + +Best wishes + +Mark + + +Mark Walters (2): + contrib: pick: remove hack notmuch-pick-show-match-message-with-wait + contrib: pick: fix refresh result + + contrib/notmuch-pick/notmuch-pick.el | 60 ++++++++++++++++----------------- + 1 files changed, 29 insertions(+), 31 deletions(-) + +-- +1.7.9.1 +