From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 22 Sep 2010 19:15:37 +0000 (-0700)
Subject: CodingGuidelines: spell Arithmetic Expansion with $(($var))
X-Git-Tag: v1.7.3.1~13
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=055467dd4ae7fac2cf3149352710a5ee64b2138c;p=git.git

CodingGuidelines: spell Arithmetic Expansion with $(($var))

POSIX wants shells to support both "N" and "$N" and requires them to yield
the same answer to $((N)) and $(($N)), but we should aim for portability
in a case like this, especially when the price we pay to do so is so
small, i.e. a few extra dollars.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index b8bf618a3..8346c1972 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -43,6 +43,10 @@ For shell scripts specifically (not exhaustive):
 
  - We use Arithmetic Expansion $(( ... )).
 
+ - Inside Arithmetic Expansion, spell shell variables with $ in front
+   of them, as some shells do not grok $((x)) while accepting $(($x))
+   just fine (e.g. dash older than 0.5.4).
+
  - No "Substring Expansion" ${parameter:offset:length}.
 
  - No shell arrays.