From: Tomi Ollila Date: Tue, 29 Oct 2013 11:03:49 +0000 (+0200) Subject: Re: [PATCH 1/4] test: Add compact test X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0521bc28f8e50926ee02cdb2606a39e792bc31ba;p=notmuch-archives.git Re: [PATCH 1/4] test: Add compact test --- diff --git a/28/0ee2c570af31d093253195beaa9d33d2996d07 b/28/0ee2c570af31d093253195beaa9d33d2996d07 new file mode 100644 index 000000000..e9d1ffbd2 --- /dev/null +++ b/28/0ee2c570af31d093253195beaa9d33d2996d07 @@ -0,0 +1,140 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 532EB431FB6 + for ; Tue, 29 Oct 2013 04:04:05 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id KaSEYSjBary3 for ; + Tue, 29 Oct 2013 04:03:59 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id AA573431FAF + for ; Tue, 29 Oct 2013 04:03:59 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 163B51000B2; + Tue, 29 Oct 2013 13:03:50 +0200 (EET) +From: Tomi Ollila +To: Ben Gamari , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/4] test: Add compact test +In-Reply-To: <1382998997-9938-1-git-send-email-bgamari.foss@gmail.com> +References: <1382998997-9938-1-git-send-email-bgamari.foss@gmail.com> +User-Agent: Notmuch/0.16+119~g219c55f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 29 Oct 2013 11:04:05 -0000 + +On Tue, Oct 29 2013, Ben Gamari wrote: + +> Signed-off-by: Ben Gamari +> --- + +Patches 2, 3 & 4 Looks OK To Me. Thanks. A few comments on this patch +inline: + +> test/compact | 35 +++++++++++++++++++++++++++++++++++ +> test/notmuch-test | 1 + +> 2 files changed, 36 insertions(+) +> create mode 100755 test/compact +> +> diff --git a/test/compact b/test/compact +> new file mode 100755 +> index 0000000..54e85ab +> --- /dev/null +> +++ b/test/compact +> @@ -0,0 +1,35 @@ +> +#!/usr/bin/env bash +> +test_description='"notmuch compact"' +> +. ./test-lib.sh +> + +> +add_message '[subject]=One' +> +add_message '[subject]=Two' +> +add_message '[subject]=Three' +> + +> +notmuch tag +tag1 \* +> +notmuch tag +tag2 subject:Two +> +notmuch tag -tag1 +tag3 subject:Three +> + +> +test_begin_subtest "Compacting" +> +notmuch compact +> +test_expect_success "compact" "notmuch compact" + +test_expect_success executes "$2" ("notmuch compact" in this case) +do you mean to run notmuch 'compact twice' ? + +> +notmuch search \* +> +output=$(notmuch search \* | notmuch_search_sanitize) + +Now do you mean to run 'notmuch search \*' twice ? + +> +test_expect_equal "$output" "\ +> +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; One (inbox tag1 unread) +> +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Two (inbox tag1 tag2 unread) +> +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Three (inbox tag3 unread)" +> + +> +test_begin_subtest "Restoring backup" +> +rm -Rf ${TEST_TMPDIR}/mail/xapian +> +mv ${TEST_TMPDIR}/mail/xapian.old ${TEST_TMPDIR}/mail/xapian +> + +> +notmuch search \* +> +output=$(notmuch search \* | notmuch_search_sanitize) + +again... ? + + +... actually David Bremner had even more insightful comments in +id:874n8cw2yq.fsf@zancas.localnet to these same issues :D + + +Tomi + + +> +test_expect_equal "$output" "\ +> +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; One (inbox tag1 unread) +> +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Two (inbox tag1 tag2 unread) +> +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Three (inbox tag3 unread)" +> + +> +test_done +> diff --git a/test/notmuch-test b/test/notmuch-test +> index aa28bb0..ec94baf 100755 +> --- a/test/notmuch-test +> +++ b/test/notmuch-test +> @@ -19,6 +19,7 @@ cd $(dirname "$0") +> TESTS=" +> basic +> help-test +> + compact +> config +> setup +> new +> -- +> 1.8.3.2 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch