From: David Bremner Date: Fri, 10 Jun 2016 11:09:36 +0000 (+2100) Subject: Re: [PATCH] WIP: regexp matching in 'subject' and 'from' X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=04e8bf2c057a92596a61f7e516e93b21578a45e7;p=notmuch-archives.git Re: [PATCH] WIP: regexp matching in 'subject' and 'from' --- diff --git a/b4/7fb393eff72b4c089745b7af0bfa37c6eed4f1 b/b4/7fb393eff72b4c089745b7af0bfa37c6eed4f1 new file mode 100644 index 000000000..9852b6d10 --- /dev/null +++ b/b4/7fb393eff72b4c089745b7af0bfa37c6eed4f1 @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id E4B576DE0130 + for ; Fri, 10 Jun 2016 04:09:54 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.011 +X-Spam-Level: +X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5 + tests=[AWL=-0.000, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id PZu8NoImkOhO for ; + Fri, 10 Jun 2016 04:09:47 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 0DEB96DE0032 + for ; Fri, 10 Jun 2016 04:09:45 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1bBKJY-0000qP-RE; Fri, 10 Jun 2016 07:09:24 -0400 +Received: (nullmailer pid 24932 invoked by uid 1000); + Fri, 10 Jun 2016 11:09:36 -0000 +From: David Bremner +To: Gaute Hope , Austin Clements +Cc: sfischme@uwaterloo.ca, notmuch +Subject: Re: [PATCH] WIP: regexp matching in 'subject' and 'from' +In-Reply-To: <1465547660-astroid-0-nudmv20lbk-1296@strange> +References: <1465265149-7174-1-git-send-email-david@tethera.net> + <1465525688-30913-1-git-send-email-david@tethera.net> + <1465547660-astroid-0-nudmv20lbk-1296@strange> +User-Agent: Notmuch/0.22+28~gb9bf3f4 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Fri, 10 Jun 2016 08:09:36 -0300 +Message-ID: <87a8itxpu7.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 10 Jun 2016 11:09:55 -0000 + +Gaute Hope writes: + +> +> Cool! +> +> Would it break a lot of things if you just replace the original prefix? + +It would change the matching behaviour. I guess there are people that +like the current "sloppy" matching of from: and subject:. In my +not-very-scientific tests, it is a factor of 5 to 10 times slower to do +regexp search, which makes sense because it is effectively post +processing the results from Xapian. At least on my system it seems fast +enough to be usable interactively, but that is a pretty shocking +performance regression. And I know there are people with more mail on +slower systems. + +> Could it be made to work on the message body? + +See Austin's previous reply for the details, but basically no; these +"values" index in terms of whole strings, while the body is indexed by +terms (roughly, words). In principle we could add a value slot for the +body, but I think that would at least double the size of the database +(maybe more).