From: David Bremner <david@tethera.net>
Date: Tue, 15 Jul 2014 01:07:40 +0000 (+2100)
Subject: Re: [PATCH] emacs: tree/show remove duplicate function
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=041f60b4804d6b0e6a670ca8fc9e65dfef6a7982;p=notmuch-archives.git

Re: [PATCH] emacs: tree/show remove duplicate function
---

diff --git a/f0/517fe3a773cc31f330434b58477da4399cd716 b/f0/517fe3a773cc31f330434b58477da4399cd716
new file mode 100644
index 000000000..58bdaebce
--- /dev/null
+++ b/f0/517fe3a773cc31f330434b58477da4399cd716
@@ -0,0 +1,63 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 12482431FC0
+	for <notmuch@notmuchmail.org>; Mon, 14 Jul 2014 18:07:53 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Iq3EnedExGyv for <notmuch@notmuchmail.org>;
+	Mon, 14 Jul 2014 18:07:49 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 9F0E8431FBC
+	for <notmuch@notmuchmail.org>; Mon, 14 Jul 2014 18:07:49 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1X6rDc-0006j4-EW; Mon, 14 Jul 2014 22:07:44 -0300
+Received: (nullmailer pid 8159 invoked by uid 1000); Tue, 15 Jul 2014
+	01:07:40 -0000
+From: David Bremner <david@tethera.net>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] emacs: tree/show remove duplicate function
+In-Reply-To: <1402134668-18587-1-git-send-email-markwalters1009@gmail.com>
+References: <1402134668-18587-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.18.1+37~gde262a2 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Mon, 14 Jul 2014 22:07:40 -0300
+Message-ID: <87a98bbfab.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 15 Jul 2014 01:07:53 -0000
+
+Mark Walters <markwalters1009@gmail.com> writes:
+> +		   (cond ((eq major-mode 'notmuch-show-mode)
+> +			  (notmuch-show-get-message-properties))
+> +			 ((eq major-mode 'notmuch-tree-mode)
+> +			  (notmuch-tree-get-message-properties))))
+
+I see this already existed, but it looks weird to me to have a two test
+cond with no else. Is it intentional to have the code drop through and
+do nothing if neither case matches?  It seems like it might be better to
+signal an error.
+
+d