From: Austin Clements Date: Tue, 4 Jun 2013 04:01:02 +0000 (+2000) Subject: Re: [PATCH] emacs: remove hardcoded defaults values from docstrings X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=033e0dce79ada94ec53ea908946e0996ec8d759b;p=notmuch-archives.git Re: [PATCH] emacs: remove hardcoded defaults values from docstrings --- diff --git a/a4/8a1cac5b568ade475588d0b7ead44c259aa0d7 b/a4/8a1cac5b568ade475588d0b7ead44c259aa0d7 new file mode 100644 index 000000000..c08a47047 --- /dev/null +++ b/a4/8a1cac5b568ade475588d0b7ead44c259aa0d7 @@ -0,0 +1,127 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id ADB69431FB6 + for ; Mon, 3 Jun 2013 21:01:20 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5gc8N4NI32+U for ; + Mon, 3 Jun 2013 21:01:12 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu + [18.9.25.15]) + by olra.theworths.org (Postfix) with ESMTP id 6A440431FAE + for ; Mon, 3 Jun 2013 21:01:12 -0700 (PDT) +X-AuditID: 1209190f-b7fb76d0000008e6-bd-51ad6687b336 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id 47.2B.02278.7866DA15; Tue, 4 Jun 2013 00:01:11 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r54418Mt003154; + Tue, 4 Jun 2013 00:01:09 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r54413wI015380 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Tue, 4 Jun 2013 00:01:07 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1UjiQh-0004vR-4U; Tue, 04 Jun 2013 00:01:03 -0400 +Date: Tue, 4 Jun 2013 00:01:02 -0400 +From: Austin Clements +To: david@tethera.net +Subject: Re: [PATCH] emacs: remove hardcoded defaults values from docstrings +Message-ID: <20130604040102.GJ5999@mit.edu> +References: <1370181885-23021-1-git-send-email-david@tethera.net> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1370181885-23021-1-git-send-email-david@tethera.net> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IR4hTV1m1PWxtosPU0m8XGZT+ZLW60djNa + XL85k9mB2eNX21xmj2erbjF7bDn0njmAOYrLJiU1J7MstUjfLoEr43xLO1NBo1DF0uONbA2M + 5/m6GDk5JARMJFZu2MoKYYtJXLi3nq2LkYtDSGAfo8TaK59ZIJwNjBLH/k2Fypxikji48BMT + hLOEUaLhx2wmkH4WARWJP8dms4HYbAIaEtv2L2cEsUUERCVOb5oEtoNZwF5i0exJ7CC2sICP + xP2N14DqOTh4BbQlGnvTQEwhAUeJNysFQSp4BQQlTs58wgLRqSVx499LJpASZgFpieX/OEDC + nAJOEp+nrwdbKgp0wJST29gmMArNQtI9C0n3LITuBYzMqxhlU3KrdHMTM3OKU5N1i5MT8/JS + i3RN9HIzS/RSU0o3MYIDXZJ/B+O3g0qHGAU4GJV4eBW2rAkUYk0sK67MPcQoycGkJMp7In5t + oBBfUn5KZUZicUZ8UWlOavEhRgkOZiUR3l4XoBxvSmJlVWpRPkxKmoNFSZz3aspNfyGB9MSS + 1OzU1ILUIpisDAeHkgSvVCpQo2BRanpqRVpmTglCmomDE2Q4D9BwFpAa3uKCxNzizHSI/ClG + RSlxXnuQhABIIqM0D64XloheMYoDvSLMyw5SxQNMYnDdr4AGMwENnvx6FcjgkkSElFQD46Tq + T2UWs3+dd80/vXjKlnWyKWrM9SrGNY2N92bV3rq/TNZA/7Gr7PItD9gz+LjPSf1rz+S7aMk4 + T+fP4U79Gd7WDVU7/XKtb267K+V58KvA6w3FgTYVFzwNmgW7U7Uz2T8F6FhcW7qlN0LtR09W + ifAU4/DX/38/aPz+2iR94rbj9pU1Nxh3KbEUZyQaajEXFScCABBqtHEfAwAA +Cc: notmuch@notmuchmail.org, David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Jun 2013 04:01:20 -0000 + +I realize this already got pushed, but to me this seems like a +reversion for the 95% of users who haven't customized +notmuch-archive-tags and just want to know that archiving means +removing the inbox tag. Why is this less confusing? Users who have +customized notmuch-archive-tags will probably know that the "default" +doesn't apply to them. + +Quoth david@tethera.net on Jun 02 at 11:04 am: +> From: David Bremner +> +> These functions refer to default values of variables, but it seems +> less confusing and less likely to get out of date to just allow the +> user to follow the help cross-reference links. +> --- +> emacs/notmuch-show.el | 14 ++++++-------- +> 1 file changed, 6 insertions(+), 8 deletions(-) +> +> another proposed change from our notmuch-pick discussions. +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 613e666..600e802 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -1835,10 +1835,9 @@ search results instead." +> "Archive each message in thread. +> +> Archive each message currently shown by applying the tag changes +> -in `notmuch-archive-tags' to each (remove the \"inbox\" tag by +> -default). If a prefix argument is given, the messages will be +> -\"unarchived\", i.e. the tag changes in `notmuch-archive-tags' +> -will be reversed. +> +in `notmuch-archive-tags' to each. If a prefix argument is given, +> +the messages will be \"unarchived\", i.e. the tag changes in +> +`notmuch-archive-tags' will be reversed. +> +> Note: This command is safe from any race condition of new messages +> being delivered to the same thread. It does not archive the +> @@ -1865,10 +1864,9 @@ buffer." +> "Archive the current message. +> +> Archive the current message by applying the tag changes in +> -`notmuch-archive-tags' to it (remove the \"inbox\" tag by +> -default). If a prefix argument is given, the message will be +> -\"unarchived\", i.e. the tag changes in `notmuch-archive-tags' +> -will be reversed." +> +`notmuch-archive-tags' to it. If a prefix argument is given, the +> +message will be \"unarchived\", i.e. the tag changes in +> +`notmuch-archive-tags' will be reversed." +> (interactive "P") +> (when notmuch-archive-tags +> (apply 'notmuch-show-tag-message