From: Tomi Ollila Date: Wed, 17 Jun 2015 11:16:03 +0000 (+0300) Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=0336f38a8c4cceb61d1f6637e49ab31d1b1a1555;p=notmuch-archives.git Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable --- diff --git a/6b/b9fa59bf1dff518d5dae85cffbd05c1309cd0f b/6b/b9fa59bf1dff518d5dae85cffbd05c1309cd0f new file mode 100644 index 000000000..2733c788b --- /dev/null +++ b/6b/b9fa59bf1dff518d5dae85cffbd05c1309cd0f @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 1BCEC6DE0243 + for ; Wed, 17 Jun 2015 04:16:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.974 +X-Spam-Level: +X-Spam-Status: No, score=0.974 tagged_above=-999 required=5 tests=[AWL=0.322, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id o9sJRZr2-vA8 for ; + Wed, 17 Jun 2015 04:16:28 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 8ACF56DE01F5 + for ; Wed, 17 Jun 2015 04:16:27 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 643C7100086; + Wed, 17 Jun 2015 14:16:03 +0300 (EEST) +From: Tomi Ollila +To: Jinwoo Lee , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable +In-Reply-To: <87vbem26qk.fsf@maritornes.cs.unb.ca> +References: <1433142542-2307-3-git-send-email-david@tethera.net> + <1434261524-14139-1-git-send-email-david@tethera.net> + + <87r3peye4q.fsf@maritornes.cs.unb.ca> + + <87oaki3zrh.fsf@maritornes.cs.unb.ca> + + + + + + <87vbem26qk.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20+12~gf3d9440 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 17 Jun 2015 11:16:31 -0000 + +On Wed, Jun 17 2015, David Bremner wrote: + +> Jinwoo Lee writes: +>> FAIL PATH is set to build directory +>> --- T000-basic.11.expected 2015-06-16 23:40:30.000000000 +0000 +>> +++ T000-basic.11.output 2015-06-16 23:40:30.000000000 +0000 +>> @@ -1 +1 @@ +>> -/Users/jinwoo/Box Sync/personal/project/notmuch +>> + +>> usage: dirname path +> +> This failure is because of spaces in your pathname. It might be simpler +> to run in a different directory rather than fix all the problems this +> causes in the test suite. + +Yes.. space in pathname also causes that 'ambiquous redirect'. + +Please use a directory which absolute path does not contain spaces (nor +tabs nor newline ;/) -- it would be quite a big project to make test +suite work with whitespace in filename and still something might broke +so it is not worth an effort. + +Probably not all tests will succeed anyway, but if you get relevant +tests to work then that should be good enough... + +Tomi + +> +>> FAIL notmuch is compiled with debugging symbols +>> --- T000-basic.12.expected 2015-06-16 23:40:30.000000000 +0000 +>> +++ T000-basic.12.output 2015-06-16 23:40:30.000000000 +0000 +>> @@ -1 +1 @@ +>> -1 +>> +0 +>> ./T000-basic.sh: line 95: readelf: command not found +> +> This test, as it says, is testing if notmuch was compiled with debugging +> symbols. Rather than yet another special case for mac, I'd be curious +> if there is a portable test for this (perhaps using nm?). In any case, +> this one test failing should not be fatal. + +yes, there is just one (1) test in the whole suite (last one in T000-basic) +that uses readelf. + +> +>> ./test-lib.sh: line 1062: $test_results_path: ambiguous redirect +>> ./test-lib.sh: line 1063: $test_results_path: ambiguous redirect +>> ./test-lib.sh: line 1064: $test_results_path: ambiguous redirect +>> ./test-lib.sh: line 1065: $test_results_path: ambiguous redirect +>> ./test-lib.sh: line 1066: $test_results_path: ambiguous redirect +>> ./test-lib.sh: line 1067: $test_results_path: ambiguous redirect +> +> At a guess, this again has to do with spaces in the pathname. Maybe this +> is fixable with more quoting, but it's really independent of mac vs +> gnu/linux. In this instance it looks like quoting "test_results_path" +> would help.