From: Jani Nikula Date: Fri, 24 Jan 2014 09:54:15 +0000 (+0100) Subject: Re: [PATCH 6/7] cli: add --quiet option to notmuch new X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=02a1a222fbbe132f455d0c065b220f0ef500a461;p=notmuch-archives.git Re: [PATCH 6/7] cli: add --quiet option to notmuch new --- diff --git a/ac/a2f5f6261eeadd3b5c988a6f440a7748f7ed42 b/ac/a2f5f6261eeadd3b5c988a6f440a7748f7ed42 new file mode 100644 index 000000000..2a1ea36d1 --- /dev/null +++ b/ac/a2f5f6261eeadd3b5c988a6f440a7748f7ed42 @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E492F431FB6 + for ; Fri, 24 Jan 2014 01:54:35 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QTsHUC1Ekvr9 for ; + Fri, 24 Jan 2014 01:54:31 -0800 (PST) +Received: from mail-bk0-f45.google.com (mail-bk0-f45.google.com + [209.85.214.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EC3DD431FAF + for ; Fri, 24 Jan 2014 01:54:30 -0800 (PST) +Received: by mail-bk0-f45.google.com with SMTP id v16so1021845bkz.4 + for ; Fri, 24 Jan 2014 01:54:29 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=xdVuC1aN/hzZsA1m3ePI5bg7lGO3c4JDi98xrmalqtM=; + b=fpbvJbZ/r6MlP8y/LD1kM8jCBJXioETL8PnSUXyk0axmtcikMWnhF2I/DNhBKCEVgE + B6wbk9yEiOsZ04BKyd2DVXv2/15s4CngxBQHwYboxDWC8s+Pxu2pnodhr12ZmFZzG5s6 + oGr3+u6zLcaVWaqodlq/Nlc7o5HmzLGMlVj3rPiApBNyzmmB6w8mygFSI4jFU5oXN/cL + nKr/6TB8j5NxSgb2uyPGjtXe7wkRDuV3k81jA3v2muiRqT6UA9KCbF1MorfVzmejXpur + FeOHmVLsaKWTHiWNTtJaNppOOKVvRj4+FSXLUw3yho2jzQEXAggHtbdF3UH24sDqJckw + y/bQ== +X-Gm-Message-State: + ALoCoQk2feOzt/uSRTvMNDT+11YnltMDkrTqjNx1MhuHVDu5b3yz40AjYeqpt/nWSabdDkwoC1WW +X-Received: by 10.204.116.70 with SMTP id l6mr298262bkq.130.1390557268091; + Fri, 24 Jan 2014 01:54:28 -0800 (PST) +Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) + by mx.google.com with ESMTPSA id d5sm2219017bkc.9.2014.01.24.01.54.26 + for + (version=TLSv1.1 cipher=RC4-SHA bits=128/128); + Fri, 24 Jan 2014 01:54:27 -0800 (PST) +From: Jani Nikula +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 6/7] cli: add --quiet option to notmuch new +In-Reply-To: <87txctah9h.fsf@qmul.ac.uk> +References: + <276371280dfbf8d98a9970b68910e1c030769641.1390163335.git.jani@nikula.org> + <87txctah9h.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.17~rc2+18~gab1d8e8 (http://notmuchmail.org) Emacs/23.2.1 + (x86_64-pc-linux-gnu) +Date: Fri, 24 Jan 2014 10:54:15 +0100 +Message-ID: <87iot91z94.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 24 Jan 2014 09:54:36 -0000 + +On Fri, 24 Jan 2014, Mark Walters wrote: +> I am not sure I like doing the database upgrade with no comment to the +> user at all. + +I think --quiet should mean we don't write to stdout at all. So the +question becomes, is the database upgrade worth warning about in stderr? + +> In fact I am not sure I like doing the upgrade without being +> specifically told to (e.g. it does not give the user a clear chance to +> backup the database first) +> +> What would people think about having a --upgrade-database option to +> notmuch new? + +We discussed this at length on IRC some time ago. I think we concluded +we should continue doing it automatically, but I'll post a summary when +I have the time. + +BR, +Jani.