From: Zac Medico Date: Tue, 9 Aug 2011 06:44:17 +0000 (-0700) Subject: repoman: check more helper calls for $D, $ED... X-Git-Tag: v2.2.0_alpha51~5 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=022e09dd6ddd8372a9ec2ef2284b7cb174e6e6b2;p=portage.git repoman: check more helper calls for $D, $ED... This adds docinto, docompress, fowners and fperms to the variable.usedwithhelpers check. Notably absent is dosed since that supports mixed input. This will fix bug #377303. --- diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index e7472df72..bff4b1fbf 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -341,7 +341,7 @@ class NoOffsetWithHelpers(LineCheck): repoman_check_name = 'variable.usedwithhelpers' # Ignore matches in quoted strings like this: # elog "installed into ${ROOT}usr/share/php5/apc/." - re = re.compile(r'^[^#"\']*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*') + re = re.compile(r'^[^#"\']*\b(docinto|docompress|dodir|dohard|exeinto|fowners|fperms|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*') error = errors.NO_OFFSET_WITH_HELPERS class ImplicitRuntimeDeps(LineCheck):