From: Tomi Ollila Date: Sat, 8 Feb 2014 19:37:43 +0000 (+0200) Subject: Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=020f62eb1b98b22a7b0fe3014d9d079813a857f5;p=notmuch-archives.git Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring --- diff --git a/e6/4e00f3ddaf8f314bc3a9c820a407ffd15a6ffd b/e6/4e00f3ddaf8f314bc3a9c820a407ffd15a6ffd new file mode 100644 index 000000000..7cf2876ba --- /dev/null +++ b/e6/4e00f3ddaf8f314bc3a9c820a407ffd15a6ffd @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6D72A431FBD + for ; Sat, 8 Feb 2014 11:38:02 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EpNPPKrIhPLg for ; + Sat, 8 Feb 2014 11:37:55 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 960F6431FBC + for ; Sat, 8 Feb 2014 11:37:55 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id D1DF5100033; + Sat, 8 Feb 2014 21:37:43 +0200 (EET) +From: Tomi Ollila +To: "W. Trevor King" +Subject: Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general + refactoring +In-Reply-To: <20140208190923.GE14197@odin.tremily.us> +References: + <20140204191453.GV14197@odin.tremily.us> + + + <20140205152738.GJ14197@odin.tremily.us> + + <20140206181400.GP14197@odin.tremily.us> + <87ob2hogkr.fsf@zancas.localnet> + <20140208171617.GD14197@odin.tremily.us> + + <20140208190923.GE14197@odin.tremily.us> +User-Agent: Notmuch/0.17+69~g761b031 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 08 Feb 2014 19:38:02 -0000 + +On Sat, Feb 08 2014, "W. Trevor King" wrote: + +> On Sat, Feb 08, 2014 at 08:29:41PM +0200, Tomi Ollila wrote: +>> On Sat, Feb 08 2014, W. Trevor King wrote: +>> > On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: +>> >>=20 +>> >> yeah, the colour scheme is not my favourite. For the sake of being +>> >> semi-constructive, I attach an alternative suggestion #ffd96e and +>> >> #bce. +>> > +>> > Works for me. +>>=20 +>> I'm fine with that too. +> +> Updated in my example and nmbug-status-python3 branch. +> +>> >> More importantly some of the threads are run together: e.g.=20 +>> >>=20 +>> >> id:"4eddf2b1.4288980a.0b74.5557@mx.google.com" and +>> >> id:"E1RYMYd-0003wu-Ea@thinkbox.jade-hamburg.de" +>> > +>> > Both of those messages are part of the same thread +>> > (thread:000000000000eaab on my box, but I doubt thread IDs are +>> > portable), so I don't add a thread-separating space between them. +>> > Would you like more message-separating space even between messages +>> > in the same thread? +>>=20 +>> =E2=80=A6 +>>=20 +>> I think the more space does not fix anything but it might help +>> regognizing message boundaries a bit (and thus would be a nice +>> feature). +> +> Added to my example and nmbug-status-python3 branch. I'm using CSS +> for this new spacing, so non-CSS browsers (e.g. w3m) won't render the +> inter-message spacing. I think the colored-link (second message row) +> vs. default id (first message row) makes inter-message separation +> clear enough in that case. + +The 2 0.5em:s adds up to 1em between messages and that IMHO makes the +messages be too far apart from each other. I changed the padding-top +and padding-bottom values to 0.25em which IMHO is better... + +> Cheers, +> Trevor + +Tomi