From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 11 Jan 2008 11:37:09 +0000 (-0000)
Subject: Add a DESCRIPTION.toolong warning for when the DESCRIPTION line is
X-Git-Tag: v2.1.4~9
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=020d2ce7c8a81434de1d86d67e9594875720f3db;p=portage.git

Add a DESCRIPTION.toolong warning for when the DESCRIPTION line is
over 80 characters long. Thanks to Betelgeuse for the patch.
(trunk r9177)

svn path=/main/branches/2.1.2/; revision=9181
---

diff --git a/bin/repoman b/bin/repoman
index 738746e67..9b721e96f 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -34,6 +34,8 @@ if not hasattr(__builtins__, "set"):
 exename=os.path.basename(sys.argv[0])	
 version="1.2"	
 
+# 14 is the length of DESCRIPTION=""
+max_desc_len = 80 - 14
 allowed_filename_chars="a-zA-Z0-9._-+:"
 allowed_filename_chars_set = {}
 map(allowed_filename_chars_set.setdefault, map(chr, range(ord('a'), ord('z')+1)))
@@ -168,6 +170,7 @@ qahelp={
 	"KEYWORDS.stupid":"Ebuilds that use KEYWORDS=-* instead of package.mask", 
 	"LICENSE.missing":"Ebuilds that have a missing or empty LICENSE variable",
 	"DESCRIPTION.missing":"Ebuilds that have a missing or empty DESCRIPTION variable",
+	"DESCRIPTION.toolong":"DESCRIPTION line is over 80 characters",
 	"EAPI.unsupported":"Ebuilds that have an unsupported EAPI version (you must upgrade portage)",
 	"SLOT.missing":"Ebuilds that have a missing or empty SLOT variable",
 	"HOMEPAGE.missing":"Ebuilds that have a missing or empty HOMEPAGE variable",
@@ -229,6 +232,7 @@ qawarnings=[
 "DEPEND.badmasked","RDEPEND.badmasked","PDEPEND.badmasked",
 "DEPEND.badindev","RDEPEND.badindev","PDEPEND.badindev",
 "DEPEND.badmaskedindev","RDEPEND.badmaskedindev","PDEPEND.badmaskedindev",
+"DESCRIPTION.toolong",
 "IUSE.invalid",
 "KEYWORDS.stupid",
 "KEYWORDS.missing",
@@ -1449,6 +1453,13 @@ for x in scanlist:
 				stats[myqakey]=stats[myqakey]+1
 				fails[myqakey].append(x+"/"+y+".ebuild")
 
+		# 14 is the length of DESCRIPTION=""
+		if len(myaux['DESCRIPTION']) > max_desc_len:
+			stats['DESCRIPTION.toolong'] += 1
+			fails['DESCRIPTION.toolong'].append(
+				"%s: DESCRIPTION is %d characters (max %d)" % \
+				(relative_path, len(myaux['DESCRIPTION']), max_desc_len))
+
 		keywords = myaux["KEYWORDS"].split()
 		stable_keywords = []
 		for keyword in keywords: