From: Austin Clements Date: Thu, 30 May 2013 01:01:33 +0000 (+2000) Subject: Re: [PATCH 0/4] emacs: Part command improvements X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=019c0787cae1c5c5d12b4642b24923a0c3738229;p=notmuch-archives.git Re: [PATCH 0/4] emacs: Part command improvements --- diff --git a/ee/e431466b60266970d72fd4d0d416ff508b8ad6 b/ee/e431466b60266970d72fd4d0d416ff508b8ad6 new file mode 100644 index 000000000..9d1c85835 --- /dev/null +++ b/ee/e431466b60266970d72fd4d0d416ff508b8ad6 @@ -0,0 +1,144 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 80E2A431FAF + for ; Wed, 29 May 2013 18:01:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id FEXLb5Ujz12n for ; + Wed, 29 May 2013 18:01:40 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu + [18.9.25.15]) + by olra.theworths.org (Postfix) with ESMTP id BE07C431FAE + for ; Wed, 29 May 2013 18:01:40 -0700 (PDT) +X-AuditID: 1209190f-b7f256d000005616-b4-51a6a4f3ea64 +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id 6A.10.22038.3F4A6A15; Wed, 29 May 2013 21:01:39 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r4U11bLo028540; + Wed, 29 May 2013 21:01:38 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r4U11Yjd031243 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Wed, 29 May 2013 21:01:36 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1UhrFG-0007j4-4P; Wed, 29 May 2013 21:01:34 -0400 +Date: Wed, 29 May 2013 21:01:33 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH 0/4] emacs: Part command improvements +Message-ID: <20130530010133.GY5999@mit.edu> +References: <1369687594-31774-1-git-send-email-amdragon@mit.edu> + <87zjvghx82.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87zjvghx82.fsf@qmul.ac.uk> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT0f28ZFmgwapWBYvVc3ksrt+cyezA + 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZaz7/pyl4Lh4xcYP15kaGE8LdTFycEgImEh8 + +cHaxcgJZIpJXLi3nq2LkYtDSGAfo8Skh1eZIJyNjBI/Xx9ghHBOM0nMutzNDuEsYZRYMmsZ + WD+LgKpE18QtbCA2m4CGxLb9yxlBbBEBHYnbhxawg9jMAtIS3343M4HYwgKWEu17D4DV8Apo + Sxz92AbWKyQQJ/Gi6SU7RFxQ4uTMJywQvVoSN/69ZAI5G2TO8n8cICYn0Kq5C8GqRQVUJKac + 3MY2gVFoFpLmWUiaZyE0L2BkXsUom5JbpZubmJlTnJqsW5ycmJeXWqRropebWaKXmlK6iREU + 0pyS/DsYvx1UOsQowMGoxMO7QWtZoBBrYllxZe4hRkkOJiVR3lJgRAjxJeWnVGYkFmfEF5Xm + pBYfYpTgYFYS4V2jDZTjTUmsrEotyodJSXOwKInzXk256S8kkJ5YkpqdmlqQWgSTleHgUJLg + jQQZKliUmp5akZaZU4KQZuLgBBnOAzTcAaSGt7ggMbc4Mx0if4pRUUqcNwokIQCSyCjNg+uF + pZxXjOJArwjzBoJU8QDTFVz3K6DBTECDxZkXgwwuSURISTUw6l1++YAxP1pZfJv9FQ5f0ytz + ph5dG3o0zTkoPriwW/dcTtjiWfusvE09Vv5ouJVaczJy4uxTDtuspXrVfr359nZ/cudV9tQq + j47mCO0JReELHtcujY+X0O35ktchqHRxV/7G+8nLXMJOMhXenlrhVBz37SenwW0986Y+DzvH + kBuHVvsYnvNWYinOSDTUYi4qTgQAOL/2ZRQDAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 30 May 2013 01:01:48 -0000 + +Quoth Mark Walters on May 27 at 11:30 pm: +> Austin Clements writes: +> +> > This is a follow-up of sorts to id:"8761ycc19t.fsf@qmul.ac.uk", where +> > Mark suggested that the part handling commands could all use the +> > correponding mm-* functions. I ran with the idea and wound up with +> > this series, which, in addition to standardizing on the mm-* functions +> > for everything and simplifying the implementation overall, decouples +> > the part commands from part buttons, which removes an entire layer +> > from the implementation and adds the ability to invoke part commands +> > with point anywhere in a part (something I often find myself wanting). +> +> Overall I really like this series. In addition to the clean up etc it +> makes it easy to export the text/plain part (which doesn't have a part +> button). I have recollection of this being difficult if it is base64 +> encoded. + +Right. That's one of the reasons I wanted a global part keymap (and +this series happened to be a convenient place to introduce that). +Also helpful is that the part bindings now appear in the show help, +which is good because I can never remember which key used the default +viewer and which prompted for a viewer. + +> I have a few small comments +> +> As mentioned on irc (just included here in case other people are +> testing) make-composed-keymap is emacs 24 only. + +I've removed the button map entirely, so this is no longer a problem. + +> This does change the default directory for saving: not serious but it's +> probably worth deciding do we want to use mailcap-download-directory or +> home or where emacs was started or? + +I don't really care what the default directory is, as long as we're +consistent, which we currently aren't. mm-default-directory seems +like a fine thing to be consistent with, since we use mm for +everything else. + +> I don't know if we want to keep a special keymap for the button or just +> always use the . prefix; the advantage is that you don't have 's' on a +> button acting differently from 's' in the text (which has annoyed me +> several times) otoh it is the extra keystroke which may annoy people +> too. Let the bikeshedding begin! (obviously return for the default +> action would remain. + +I'm all for removing the special button keymap. The less hidden +functionality the better. + +> Would it be worth having . return in the part body as the default +> action ? + +I played with this for a while and eventually decided it wasn't worth +the effort. Maybe in a followup. + +> Finally, with message indenting it's the start/end of the part are a +> little unclear. I think it's the [ of the part button at the start of +> the part to the character before the [ of the next part button. In +> particular on the line of a new part but before the button is still the +> old part. Since parts are whole lines it would be nice if the region +> were line based but I don't know if that is easy. + +Fixed in v2. + +> Best wishes +> +> Mark