From: Jeff King Date: Sat, 7 Mar 2009 17:14:04 +0000 (-0500) Subject: t1300: use test_must_fail as appropriate X-Git-Tag: v1.6.2.1~10 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=003f69b282f9cc54da771e1b3e9378aa3f5178cd;p=git.git t1300: use test_must_fail as appropriate Some of the tests checked the exit code manually, even going so far as to run git outside of the test_expect harness. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh index 11b82f43d..3c06842d9 100755 --- a/t/t1300-repo-config.sh +++ b/t/t1300-repo-config.sh @@ -336,10 +336,10 @@ test_expect_success 'get bool variable with empty value' \ 'git config --bool emptyvalue.variable > output && cmp output expect' -git config > output 2>&1 - -test_expect_success 'no arguments, but no crash' \ - "test $? = 129 && grep usage output" +test_expect_success 'no arguments, but no crash' ' + test_must_fail git config >output 2>&1 && + grep usage output +' cat > .git/config << EOF [a.b] @@ -373,7 +373,7 @@ EOF test_expect_success 'new variable inserts into proper section' 'cmp .git/config expect' test_expect_success 'alternative GIT_CONFIG (non-existing file should fail)' \ - 'git config --file non-existing-config -l; test $? != 0' + 'test_must_fail git config --file non-existing-config -l' cat > other-config << EOF [ein]