From: David Bremner <david@tethera.net>
Date: Sun, 6 Apr 2014 18:42:06 +0000 (+2100)
Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version... 
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=003bcc227a6c2ef3bc3ac2b582da7e721083f4ac;p=notmuch-archives.git

Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it
---

diff --git a/87/4570ad4a69111cdd1bd488d2fbbc278bd696dd b/87/4570ad4a69111cdd1bd488d2fbbc278bd696dd
new file mode 100644
index 000000000..f91534aa0
--- /dev/null
+++ b/87/4570ad4a69111cdd1bd488d2fbbc278bd696dd
@@ -0,0 +1,73 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1CD6B431FBC
+	for <notmuch@notmuchmail.org>; Sun,  6 Apr 2014 11:43:32 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Lq+zPDc+FiBt for <notmuch@notmuchmail.org>;
+	Sun,  6 Apr 2014 11:43:23 -0700 (PDT)
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
+	[87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 93333431FB6
+	for <notmuch@notmuchmail.org>; Sun,  6 Apr 2014 11:43:23 -0700 (PDT)
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
+	4.72) (envelope-from <david@tethera.net>)
+	id 1WWs1N-0004eg-FW; Sun, 06 Apr 2014 18:42:21 +0000
+Received: (nullmailer pid 10092 invoked by uid 1000); Sun, 06 Apr 2014
+	18:42:06 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create
+	notmuch-version.el from it
+In-Reply-To: <1395261431-24668-2-git-send-email-tomi.ollila@iki.fi>
+References: <1395261431-24668-1-git-send-email-tomi.ollila@iki.fi>
+	<1395261431-24668-2-git-send-email-tomi.ollila@iki.fi>
+User-Agent: Notmuch/0.17+170~gf516b7c (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sun, 06 Apr 2014 15:42:06 -0300
+Message-ID: <87a9by47wh.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: tomi.ollila@iki.fi
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 06 Apr 2014 18:43:32 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+> +;; You should have received a copy of the GNU General Public License
+> +;; along with Notmuch.  If not, see <http://www.gnu.org/licenses/>.
+
+Do you think we need a copyright header in a generated file?
+
+> +
+> +(defconst notmuch-emacs-version %VERSION%
+> +  "Version string of this version of Notmuch Emacs MUA.")
+> +
+
+At the risk of being very picky, how about less copies of Version, maybe
+"Version of Notmuch Emacs MUA"
+
+Other than that, the series looks OK, and works on Debian now.
+
+d
+