From: Mark Walters Date: Tue, 4 Nov 2014 09:23:42 +0000 (+0000) Subject: Re: [PATCH v2 00/10] "notmuch address" command X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=001b121beed03e34d798275b1bdabf468d1c2c15;p=notmuch-archives.git Re: [PATCH v2 00/10] "notmuch address" command --- diff --git a/bd/572ccce7d7569aa6eea87c49e1129b634e583b b/bd/572ccce7d7569aa6eea87c49e1129b634e583b new file mode 100644 index 000000000..840293254 --- /dev/null +++ b/bd/572ccce7d7569aa6eea87c49e1129b634e583b @@ -0,0 +1,157 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4E6F5429E40 + for ; Tue, 4 Nov 2014 01:24:11 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Vg2Q+4do3GfT for ; + Tue, 4 Nov 2014 01:24:05 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1992C429E3B + for ; Tue, 4 Nov 2014 01:24:05 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1XlaL1-0002DN-Jk; Tue, 04 Nov 2014 09:24:03 +0000 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1XlaL1-0007Dk-4s; Tue, 04 Nov 2014 09:23:43 +0000 +From: Mark Walters +To: Michal Sojka , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 00/10] "notmuch address" command +In-Reply-To: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz> +References: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz> +User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 04 Nov 2014 09:23:42 +0000 +Message-ID: <87oasn2uap.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: b6037c5c405dfeacc0a4b3464d1c2425 (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Nov 2014 09:24:11 -0000 + + +On Mon, 03 Nov 2014, Michal Sojka wrote: +> Hi all, +> +> this is v2 of "notmuch address" patchset. It obsoletes [1]. +> +> Don't be scared by the number of patches. Most of them are trivial +> refactoring. Patches 1-4 refactor the code so that "notmuch search" +> command is easier to split. Patch 5 is Jani's hierarchical command +> line parsing patch. Patch 6 splits search functionality to new address +> command. Patch 7 is minor refactoring. Patches 8-10 correspond to +> patches 5-7 in the original "notmuch search +> --output=sender/recipients" patch series [2]. +> +> Changes from v1: +> +> - Rebased to current master (conflicted with Jani's "notmuch search +> --duplicate=N with --output=messages" patch) +> - Fixed printing of false "Unrecognized option" error message in +> hierarchical command line parser. + +Overall this series looks good. My inclination is to leave patch 10 +until after the freeze but I am happy either way. Tests all work and my +testing is fine. + +A couple of other comments: + +you should add something to devel/schemata detailing the fields in the +structured address output. + +Please check the new manpage: I think some of it is slightly outdated. I +mentioned in my comments the exclude=false, but missed exclude=all. Also +the manpage could say what actually gets printed in the default text +case (in particular to emphasise that it includes the real name) + +Best wishes + +Mark + + +> +> Regards, +> -Michal +> +> [1] id:1414889400-30977-1-git-send-email-sojkam1@fel.cvut.cz +> [2] id:1414792441-29555-1-git-send-email-sojkam1@fel.cvut.cz +> +> +> Jani Nikula (1): +> cli: add support for hierarchical command line option arrays +> +> Michal Sojka (9): +> cli: search: Rename options to context +> cli: search: Move more variables into search_context_t +> cli: search: Convert ctx. to ctx-> +> cli: search: Split notmuch_search_command to smaller functions +> cli: Introduce "notmuch address" command +> cli: search: Convert --output to keyword argument +> cli: address: Do not output duplicate addresses +> cli: address: Add --output=count +> cli: address: Add --filter-by option to configure address filtering +> +> command-line-arguments.c | 16 +- +> command-line-arguments.h | 1 + +> completion/notmuch-completion.bash | 48 +++- +> completion/notmuch-completion.zsh | 11 +- +> doc/man1/notmuch-address.rst | 140 ++++++++++++ +> doc/man1/notmuch-search.rst | 21 +- +> doc/man1/notmuch.rst | 7 +- +> notmuch-client.h | 3 + +> notmuch-search.c | 454 +++++++++++++++++++++++++------------ +> notmuch.c | 2 + +> test/T095-address.sh | 148 ++++++++++++ +> test/T097-address-filter-by.sh | 73 ++++++ +> 12 files changed, 751 insertions(+), 173 deletions(-) +> create mode 100644 doc/man1/notmuch-address.rst +> create mode 100755 test/T095-address.sh +> create mode 100755 test/T097-address-filter-by.sh +> +> -- +> 2.1.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch