From: Tomi Ollila Date: Thu, 2 Feb 2012 15:25:19 +0000 (+0200) Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;ds=sidebyside;h=361430bbca797579c4bf71bfe5376873e255917b;p=notmuch-archives.git Re: [PATCH] test: make test_expect_equal_file() arguments flexible --- diff --git a/2b/fcedbe31dca4e6c63c5613e9a77072d8ca9561 b/2b/fcedbe31dca4e6c63c5613e9a77072d8ca9561 new file mode 100644 index 000000000..36f9374a9 --- /dev/null +++ b/2b/fcedbe31dca4e6c63c5613e9a77072d8ca9561 @@ -0,0 +1,79 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5BBFD431FAF + for ; Thu, 2 Feb 2012 07:25:17 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jPHip1a7hKFs for ; + Thu, 2 Feb 2012 07:25:16 -0800 (PST) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id C37E9431FAE + for ; Thu, 2 Feb 2012 07:25:16 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 9D5D768055; Thu, 2 Feb 2012 17:25:19 +0200 (EET) +From: Tomi Ollila +To: David Edmondson , + Jameson Graef Rollins , + Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible +In-Reply-To: +References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com> + <87r4yfszx9.fsf@servo.finestructure.net> + <87pqdync64.fsf@gmail.com> + <87k446n8ji.fsf@gmail.com> <87ehuetqjz.fsf@servo.finestructure.net> + +User-Agent: Notmuch/0.11+146~geb6dc33 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 02 Feb 2012 15:25:17 -0000 + +On Thu, 02 Feb 2012 14:33:56 +0000, David Edmondson wrote: +> On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins wrote: +> > If this is really a problem, I vote for 1. In general, I am not in +> > favor of making the test suite more complicated than it needs to be. +> +> After listening to the debate, I agree. The documentation should state +> that the order is 'expected actual' (or the other way around) and +> offenders should be shot on sight^W^W^Wfixed. + +I've started to agree with Dmitry. + +Why do something that computer can do -- to guide test writers to +give args in consistent order and provide suitable filenames. + +Secondly as the output files are provided for human consumption +if there is consistent naming in expected output files helps +developers getting parts of the big picture easier and finding +right filenames easier. + +... and the reviewers doesn't need to keep their plasma guns +handly. + +Tomi +