Re: [notmuch] [PATCH (rebased)] Handle message renames in mail spool

diff --git a/48/920c53c796f5482a77b20e22a445c81375ae45 b/48/920c53c796f5482a77b20e22a445c81375ae45
new file mode 100644 (file)
index 0000000..7594e65
--- /dev/null
+++ b/48/920c53c796f5482a77b20e22a445c81375ae45
@@ -0,0 +1,92 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CDD7A431FBD;\r
+       Sat,  5 Dec 2009 14:49:05 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id scJHdFuUxXin; Sat,  5 Dec 2009 14:49:04 -0800 (PST)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D8CFD431FAE;\r
+       Sat,  5 Dec 2009 14:49:04 -0800 (PST)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 981002542FB; Sat,  5 Dec 2009 14:49:04 -0800 (PST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Marten Veldthuis <marten@veldthuis.com>, Michael Alan Dorman\r
+       <mdorman@ironicdesign.com>, notmuch@notmuchmail.org\r
+In-Reply-To: <87hbs5u7kh.fsf@home.veldthuis.com>\r
+References: <1259267025-28733-1-git-send-email-dottedmag@dottedmag.net>\r
+       <1259788526-14205-1-git-send-email-dottedmag@dottedmag.net>\r
+       <87zl5zfty5.fsf@yoom.home.cworth.org>\r
+       <87k4x29732.wl%bremner@pivot.cs.unb.ca>\r
+       <87bpiefwdq.fsf@yoom.home.cworth.org> <87aaxysjdj.fsf@vertex.dottedmag>\r
+       <87aaxyfuz4.fsf@yoom.home.cworth.org>\r
+       <20091204140946.644243f0@vimes.local>\r
+       <87hbs6dzjd.fsf@yoom.home.cworth.org>\r
+       <87hbs5u7kh.fsf@home.veldthuis.com>\r
+Date: Sat, 05 Dec 2009 14:48:55 -0800\r
+Message-ID: <87zl5xca08.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Subject: Re: [notmuch] [PATCH (rebased)] Handle message renames in mail spool\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 Dec 2009 22:49:06 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sat, 05 Dec 2009 09:51:58 +0100, Marten Veldthuis <marten@veldthuis.com>=\r
+ wrote:\r
+> On Fri, 04 Dec 2009 16:39:50 -0800, Carl Worth <cworth@cworth.org> wrote:\r
+> > But when viewing an actual message, I'm still planning on having notmuch\r
+> > just return an arbitrary filename from the list of filenames associated\r
+> > with that message. Does anyone see any problem with that? Can you think\r
+> > of a case where you'd really care about seeing one or the other of\r
+> > a particular duplicated message?\r
+>=20\r
+> As long as it's deterministic. But if you don't display the first\r
+> filename received, couldn't you exploit this by spoofing message ids?\r
+\r
+What it currently does is use the filename of the first file that\r
+notmuch encounters. That's different than "first received", but either\r
+way, there's still a race condition here for active spoofing attempts.\r
+\r
+And, yes, actual intentional collisions of message IDs is something I\r
+hadn't given thought to yet. So thanks for bringing that up. It's\r
+definitely a case where you'd want to know and see the difference.\r
+\r
+So maybe what we really want to do is to display some full-context diff\r
+of the message by default, and have notmuch learn about differences the\r
+user isn't interested in seeing, (such as mailing-list footers or so).\r
+\r
+That sounds workable and should make any spoofing attempt obvious to the\r
+user.\r
+\r
+=2DCarl\r
+\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFLGuNY6JDdNq8qSWgRAtZaAJ9x0vy9l2NRNiVCMdlNt+8czC0BVQCcDRbW\r
+dpnezO8Ou8rUZ2a7Sl+kE5o=\r
+=Lqtp\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r