Re: [PATCH v2] emacs: add stash support for git send-email command line

diff --git a/6c/3d1e897d1104a94c90c476d3bd831f5bd7476b b/6c/3d1e897d1104a94c90c476d3bd831f5bd7476b
new file mode 100644 (file)
index 0000000..2d8c374
--- /dev/null
+++ b/6c/3d1e897d1104a94c90c476d3bd831f5bd7476b
@@ -0,0 +1,158 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3C2A9431FAF\r
+       for <notmuch@notmuchmail.org>; Fri,  2 Jan 2015 09:49:35 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id P6mADcrMTzp6 for <notmuch@notmuchmail.org>;\r
+       Fri,  2 Jan 2015 09:49:32 -0800 (PST)\r
+Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com\r
+ [74.125.82.52])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ D225A431FAE   for <notmuch@notmuchmail.org>; Fri,  2 Jan 2015 09:49:31 -0800\r
+ (PST)\r
+Received: by mail-wg0-f52.google.com with SMTP id x12so24356381wgg.11\r
+       for <notmuch@notmuchmail.org>; Fri, 02 Jan 2015 09:49:30 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=Jqq8nmu+Hlrz70oBoAkWMfbv+GgF9oLQEksY0vnTtKA=;\r
+       b=lJRy2JOrdZ/gjOhWG8Cd0KUVdE/PfHkVanI6FPwtVNZ1EZc+I9vTpWFD2lsiaHG+78\r
+       Ja/uEhVHrf6vbCXmLiuHCwxnC2E7rfh9K9GFGP06JCaAEpdzkV+MYwpSXiLF0x+IJgrd\r
+       HXn4I0OHZeHtBKGudyYqu10wZz987bFaAy12WJjNyzWOVJPUDX9TlzT8Q3kZdvmMnj5L\r
+       /IOed8GOgj/uKtvBPM3kcaib1iab+jrbeEqas7njGtOIuhi+eGQ6lqv4biz8WZF3RIpR\r
+       cPcw+fJ1ZGSnHZas+5SzdUH/jjGHC5CUsgMAb/Zf7Dz6BHAL5yk87sJfYd1aZ/9xFEQ8\r
+       791A==\r
+X-Gm-Message-State:\r
+ ALoCoQmtoPHMCly6gNsg9v9MK3WEH58/FOmI6Nl81FGNNJBPr+/ajoOpAny3ibCuHr8uA4Tc5hVE\r
+X-Received: by 10.194.75.195 with SMTP id e3mr96730972wjw.44.1420220970662;\r
+       Fri, 02 Jan 2015 09:49:30 -0800 (PST)\r
+Received: from localhost (mobile-internet-bceeb5-193.dhcp.inet.fi.\r
+       [188.238.181.193])\r
+       by mx.google.com with ESMTPSA id cg8sm63246636wjc.1.2015.01.02.09.49.29\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Fri, 02 Jan 2015 09:49:30 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: add stash support for git send-email command\r
+       line\r
+In-Reply-To: <cuna921smnf.fsf@gargravarr.hh.sledj.net>\r
+References: <1414525138-838-1-git-send-email-jani@nikula.org>\r
+       <1420134332-25698-1-git-send-email-jani@nikula.org>\r
+       <cuna921smnf.fsf@gargravarr.hh.sledj.net>\r
+User-Agent: Notmuch/0.19+6~gf2e3d2c (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 02 Jan 2015 19:49:37 +0200\r
+Message-ID: <874ms9139q.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 02 Jan 2015 17:49:35 -0000\r
+\r
+On Fri, 02 Jan 2015, David Edmondson <dme@dme.org> wrote:\r
+> On Thu, Jan 01 2015, Jani Nikula wrote:\r
+>> Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as\r
+>> --in-reply-to, suitable for pasting to git send-email command line.\r
+>> ---\r
+>>  emacs/notmuch-show.el | 38 ++++++++++++++++++++++++++++++++++++++\r
+>>  1 file changed, 38 insertions(+)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index b8cfbb8a3286..887d877672fc 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -1280,6 +1280,7 @@ reset based on the original query."\r
+>>      (define-key map "t" 'notmuch-show-stash-to)\r
+>>      (define-key map "l" 'notmuch-show-stash-mlarchive-link)\r
+>>      (define-key map "L" 'notmuch-show-stash-mlarchive-link-and-go)\r
+>> +    (define-key map "G" 'notmuch-show-stash-git-send-email)\r
+>>      (define-key map "?" 'notmuch-subkeymap-help)\r
+>>      map)\r
+>>    "Submap for stash commands")\r
+>> @@ -2131,6 +2132,43 @@ the user (see `notmuch-show-stash-mlarchive-link-alist')."\r
+>>    (notmuch-show-stash-mlarchive-link mla)\r
+>>    (browse-url (current-kill 0 t)))\r
+>>  \r
+>> +(defun notmuch-show-stash-git-helper (addresses prefix)\r
+>> +  "Escape, trim, quote, and add PREFIX to each address in list of\r
+>> ADDRESSES."\r
+>\r
+> "...and return the result as a single string."\r
+>\r
+>> +  (mapconcat (lambda (x)\r
+>> +          (concat prefix "\""\r
+>> +                  ;; escape double-quotes\r
+>> +                  (replace-regexp-in-string\r
+>> +                   "\"" "\\\\\""\r
+>> +                   ;; trim leading and trailing spaces\r
+>> +                   (replace-regexp-in-string\r
+>> +                    "\\(^ *\\| *$\\)" ""\r
+>> +                    x)) "\""))\r
+>> +        addresses " "))\r
+>> +\r
+>> +(put 'notmuch-show-stash-git-send-email 'notmuch-prefix-doc\r
+>> +     "Copy From/To/Cc of current message to kill-ring in a form suitable for pasting to git send-email command line.")\r
+>> +\r
+>> +(defun notmuch-show-stash-git-send-email (&optional no-in-reply-to)\r
+>> +  "Copy From/To/Cc/Message-Id of current message to kill-ring in a form suitable for pasting to git send-email command line.\r
+>> +\r
+>> +If invoked with a prefix argument (or NO-IN-REPLY-TO is non-nil,\r
+>> +omit --in-reply-to=<Message-Id>."\r
+>\r
+> Missing ")" after "non-nil".\r
+>\r
+>> +  (interactive "P")\r
+>> +  (notmuch-common-do-stash\r
+>> +   (mapconcat 'identity\r
+>> +         (remove ""\r
+>> +                 (list\r
+>> +                  (notmuch-show-stash-git-helper\r
+>> +                   (message-tokenize-header (notmuch-show-get-from)) "--to=")\r
+>> +                  (notmuch-show-stash-git-helper\r
+>> +                   (message-tokenize-header (notmuch-show-get-to)) "--to=")\r
+>> +                  (notmuch-show-stash-git-helper\r
+>> +                   (message-tokenize-header (notmuch-show-get-cc)) "--cc=")\r
+>> +                  (unless no-in-reply-to\r
+>> +                    (notmuch-show-stash-git-helper\r
+>> +                     (list (notmuch-show-get-message-id t))\r
+>> "--in-reply-to="))))\r
+>\r
+> This will still generate a trailing space if `no-in-reply-to' is set,\r
+> but I think that we can live with it.\r
+\r
+I know I can! ;)\r
+\r
+Thanks for the review, v3 in reply.\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+>\r
+>> +         " ")))\r
+>> +\r
+>>  ;; Interactive part functions and their helpers\r
+>>  \r
+>>  (defun notmuch-show-generate-part-buffer (message-id nth)\r
+>> -- \r
+>> 2.1.4\r