Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in symbol-hiding.

diff --git a/aa/7fb984950ceea462ae4d5d984ef6d66609f9e6 b/aa/7fb984950ceea462ae4d5d984ef6d66609f9e6
new file mode 100644 (file)
index 0000000..4d55d10
--- /dev/null
+++ b/aa/7fb984950ceea462ae4d5d984ef6d66609f9e6
@@ -0,0 +1,79 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0F259431FD0\r
+       for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 05:04:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id RiiYOGdKu-iX for <notmuch@notmuchmail.org>;\r
+       Fri, 25 Nov 2011 05:04:46 -0800 (PST)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6529B431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 05:04:46 -0800 (PST)\r
+Received: from convex-new.cs.unb.ca ([131.202.13.154])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id pAPD4iLZ011146;\r
+       Fri, 25 Nov 2011 09:04:44 -0400\r
+Received: from bremner by convex-new.cs.unb.ca with local (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1RTvSO-00031N-AT; Fri, 25 Nov 2011 09:04:44 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Amadeusz =?utf-8?B?xbtvxYJub3dza2k=?= <aidecoe@aidecoe.name>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in\r
+       symbol-hiding.\r
+In-Reply-To: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>\r
+References: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>\r
+User-Agent: Notmuch/0.10~rc1+12~g53b921d (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 25 Nov 2011 09:04:44 -0400\r
+Message-ID: <878vn4bbf7.fsf@convex-new.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 25 Nov 2011 13:04:47 -0000\r
+\r
+On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz =C5=BBo=C5=82nowski <aidecoe@a=\r
+idecoe.name> wrote:\r
+>=20=20\r
+> +$(dir)/symbol-test: $(dir)/symbol-test.o\r
+> +    $(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian\r
+\r
+I'm a bit surprised no -I is neaded here. Is that taken care in the CC call?\r
+\r
+>  .PHONY: test check\r
+> -test:       all $(dir)/smtp-dummy\r
+> +test:       all $(dir)/smtp-dummy $(dir)/symbol-test\r
+>      @${dir}/notmuch-test $(OPTIONS)\r
+\r
+The instructions were already wrong, but maybe they should be updated to\r
+point out that calling the test scripts directly requires smtp-dummy and\r
+symbol-test already be built. Or maybe the tests should check for these\r
+binaries as pre-reqs along with emacs, gpg, etc...=20\r
+\r
+> +       -e "/^(emacs.expected-output|smtp-dummy|smtp-dummy.c|test-verbose|sy=\r
+mbol-test.cc|symbol-test|symbol-test.o)/d" \\r
+\r
+I wonder if this should be shortened (and made a bit sloppier) with the\r
+use of regexes.\r
+\r