Re: [PATCH 6/9] search for a reasonable gpg implementation

diff --git a/7d/5ad5dbe7092d1b1f9259d1955f477716ca3f0f b/7d/5ad5dbe7092d1b1f9259d1955f477716ca3f0f
new file mode 100644 (file)
index 0000000..8a4f197
--- /dev/null
+++ b/7d/5ad5dbe7092d1b1f9259d1955f477716ca3f0f
@@ -0,0 +1,85 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 56BD66DE13EF\r
+ for <notmuch@notmuchmail.org>; Fri, 11 Dec 2015 14:22:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.015\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.015 tagged_above=-999 required=5\r
+ tests=[AWL=-0.015] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 93i4Y17zxOFz for <notmuch@notmuchmail.org>;\r
+ Fri, 11 Dec 2015 14:22:11 -0800 (PST)\r
+Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 610636DE005F\r
+ for <notmuch@notmuchmail.org>; Fri, 11 Dec 2015 14:22:11 -0800 (PST)\r
+Received: from fifthhorseman.net (unknown [38.109.115.130])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id AC5C3F984;\r
+ Fri, 11 Dec 2015 17:22:08 -0500 (EST)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id CCD90202B7; Fri, 11 Dec 2015 17:22:08 -0500 (EST)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: "J. Lewis Muir" <jlmuir@imca-cat.org>, Tomi Ollila <tomi.ollila@iki.fi>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 6/9] search for a reasonable gpg implementation\r
+In-Reply-To: <566B4BCC.7060203@imca-cat.org>\r
+References: <1449718786-28000-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1449718786-28000-7-git-send-email-dkg@fifthhorseman.net>\r
+ <m24mfo7ioy.fsf@guru.guru-group.fi> <566B4BCC.7060203@imca-cat.org>\r
+User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 11 Dec 2015 17:22:08 -0500\r
+Message-ID: <87poycfwxb.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 11 Dec 2015 22:22:13 -0000\r
+\r
+On Fri 2015-12-11 17:18:52 -0500, J. Lewis Muir wrote:\r
+> On 12/11/15 3:56 PM, Tomi Ollila wrote:\r
+>>> +static const char*\r
+>>> +_notmuch_database_get_gpg_path (notmuch_database_t *notmuch)\r
+>>> +{\r
+>>> +#define try_gpg_path(z) if (!access(z, X_OK)) return z\r
+>>> +    try_gpg_path("/usr/bin/gpg2");\r
+>>> +    try_gpg_path("/bin/gpg2");\r
+>>> +    try_gpg_path("/usr/bin/gpg");\r
+>>> +    try_gpg_path("/bin/gpg");\r
+>>> +    return NULL;\r
+>>> +}\r
+>>\r
+>> If this were to survive longer, BSD folks would like to have\r
+>> /usr/local/bin checked...\r
+>> (i don't know (yet) about os x\r
+>\r
+> I'm not following closely, but seeing paths to programs hard coded in\r
+> the source never seems like a good idea; invariably someone will have\r
+> the program in an unanticipated location.  I'm using pkgsrc on OS X,\r
+> and my gpg is at /opt/pkg/bin/gpg.  How about a Notmuch configuration\r
+> file item specifying the location of the program?  Or if not that, how\r
+> about a configuration option at build time to specify the location of\r
+> gpg that then gets hard coded in the source?  Or if not that, how about\r
+> an environment variable that will specify the location of the program\r
+> (e.g. like OpenSSH's SSH_ASKPASS environment variable)?\r
+\r
+Yes, the path search is genericized later in the series (7/9).  clearly\r
+i should have done even more commit squashing to avoid confusing people\r
+with this distraction.  point clearly taken, though; i will avoid\r
+hard-coding any paths.  thanks!\r
+\r
+            --dkg\r