Re: [PATCH 2/2] notmuch.el:notmuch-search-process-filter: Rewritten. Cope with incomp...

diff --git a/ff/018e119728390282a76bd1b4f061a1c4af4704 b/ff/018e119728390282a76bd1b4f061a1c4af4704
new file mode 100644 (file)
index 0000000..6c3245b
--- /dev/null
+++ b/ff/018e119728390282a76bd1b4f061a1c4af4704
@@ -0,0 +1,114 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CDA88431FBD\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Jun 2013 15:43:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id TdXhhqYUTCs4 for <notmuch@notmuchmail.org>;\r
+       Mon, 24 Jun 2013 15:43:48 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (dmz-mailsec-scanner-7.mit.edu\r
+       [18.7.68.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 985D7431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Jun 2013 15:43:48 -0700 (PDT)\r
+X-AuditID: 12074424-b7f228e00000096b-2f-51c8cba22d0f\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+       by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 85.31.02411.2ABC8C15; Mon, 24 Jun 2013 18:43:46 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r5OMhiEg018197; \r
+       Mon, 24 Jun 2013 18:43:45 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5OMhgBJ028802\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Mon, 24 Jun 2013 18:43:44 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1UrFU6-0005Ik-Em; Mon, 24 Jun 2013 18:43:42 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Thomas Schwinge <thomas@schwinge.name>, Carl Worth <cworth@cworth.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] notmuch.el:notmuch-search-process-filter: Rewritten.\r
+       Cope with incomplete lines.\r
+In-Reply-To: <87pqgtmxfi.fsf@kepler.schwinge.homeip.net>\r
+References: <87zkqeiffj.fsf@kepler.schwinge.homeip.net>\r
+       <1296690999-16542-3-git-send-email-thomas@schwinge.name>\r
+       <87r5ae8lem.fsf@yoom.home.cworth.org>\r
+       <87pqgtmxfi.fsf@kepler.schwinge.homeip.net>\r
+User-Agent: Notmuch/0.15.2+182~gd0bd88f (http://notmuchmail.org) Emacs/23.4.1\r
+       (i486-pc-linux-gnu)\r
+Date: Mon, 24 Jun 2013 18:43:41 -0400\r
+Message-ID: <87d2rbyvs2.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsUixG6norvo9IlAg7PrtSxu/pzDZnH95kxm\r
+       i8ZXnxkdmD12b37A4vFs1S1mj3d7p7MEMEdx2aSk5mSWpRbp2yVwZXTvlC54wF2xfNE+xgbG\r
+       dZxdjJwcEgImEvuf7WeHsMUkLtxbz9bFyMUhJLCPUeJy9xFGCGcjo8SsXc9YIJzTTBKTe/cx\r
+       QzhLGCWu7l3BCtLPJqAhsW3/ckYQW0QgR+Lat2VsILawQKbEua8LgWwODk4BC4lb55Mgeg8x\r
+       SuzYNRWsV1QgUWLSgk5mEJtFQFXi3I8DYDfxAt33fsECVghbUOLkzCcsIDazgJbEjX8vmSYw\r
+       CsxCkpqFJLWAkWkVo2xKbpVubmJmTnFqsm5xcmJeXmqRrrlebmaJXmpK6SZGcJi6qOxgbD6k\r
+       dIhRgINRiYd3RsyJQCHWxLLiytxDjJIcTEqivJNPAIX4kvJTKjMSizPii0pzUouBrudgVhLh\r
+       DRUByvGmJFZWpRblw6SkOViUxHnFbu0MFBJITyxJzU5NLUgtgsnKcHAoSfB2ngJqFCxKTU+t\r
+       SMvMKUFIM3FwggznARreB1LDW1yQmFucmQ6RP8WoKCXOOxEkIQCSyCjNg+uFpZFXjOJArwjz\r
+       FoBU8QBTEFz3K6DBTECDJ6ceBxlckoiQkmpg5GZ5L3xUbxrXhaZNetr++SlxQkpCWTGi+5Z9\r
+       rd/pJ+me6nC+Yd2U2AyJtolf9CbZdnGnZxjHb/UxDm95r8P7M1ze/Du/bsHdHe5uE3O/f76V\r
+       s/DAIkbDd5krjf96RfCtPS4zc5r8AdG3ofP3WM1+ui/ys2191YkdxmvCvmquXPzLeUNV9Sd7\r
+       JZbijERDLeai4kQAlAFwcf4CAAA=\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 24 Jun 2013 22:43:53 -0000\r
+\r
+On Tue, 15 Nov 2011, Thomas Schwinge <thomas@schwinge.name> wrote:\r
+> Hi!\r
+>\r
+> On Thu, 10 Mar 2011 18:02:09 -0800, Carl Worth <cworth@cworth.org> wrote:\r
+>> On Thu,  3 Feb 2011 00:56:39 +0100, Thomas Schwinge <thomas@schwinge.name> wrote:\r
+>> > This issue has been lying in ambush as of 2009-11-24's commit\r
+>> > 93af7b574598637c2766dd1f8ef343962c9a8efb.\r
+>> \r
+>> Thanks very much for tracking down this bug, Thomas. What a nasty bug to\r
+>> have in notmuch!\r
+>> \r
+>> Your fix seems to drop the last thread from the search results\r
+>> view. I've now committed a slightly modified fix that avoids that\r
+>> problem. I also made the test case provide slightly cleaner results.\r
+>> \r
+>> Let me know if you see any problems.\r
+>\r
+> That is much better, thanks!\r
+>\r
+> But we're not there yet...  %-| That is, today I hit another issue that\r
+> appears to hide in the same elisp code.  See ``Error: Unexpected output\r
+> From notmuch search''.  (And, thanks to eBay for long subject lines...)\r
+>\r
+> Unfortunately I'm totally out of time at the moment (final month of\r
+> writing and wrapping up my diploma thesis), so I'm just dumping my state\r
+> here, for now.\r
+\r
+*snip*\r
+\r
+I happened to notice that this is still marked as a bug.  I'm marking it\r
+as fixed.  This code was completely rewritten to use the streaming JSON\r
+parser (and now the streaming S-expression parser) and there's now a\r
+test that feeds the process filter the search data one character at a\r
+time to catch these sorts of buffer boundary bugs.\r