Re: [PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show...

diff --git a/cc/0faf9dc793e5ba8680f4ff8b48eccd447751af b/cc/0faf9dc793e5ba8680f4ff8b48eccd447751af
new file mode 100644 (file)
index 0000000..fdfbf1a
--- /dev/null
+++ b/cc/0faf9dc793e5ba8680f4ff8b48eccd447751af
@@ -0,0 +1,149 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 53CED431E64\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:22:55 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id S0Xcbictfg1Q for <notmuch@notmuchmail.org>;\r
+       Sun, 29 Jan 2012 21:22:53 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3C771431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:22:53 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so1045813bke.26\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:22:51 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=f8HD7ydswyGifemh4ENI5qa0V0qM3Rx8256Jh77K0NE=;\r
+       b=xxHesFgACoLFQiGl7QjQILHMG8vQ33dz7Ce2JA0i9VqTLIAoUqWwY1S5PH5s7jaYAO\r
+       /HUVkCzQEP6zq4fihYxcacDaZy+WiD8LVqxIZbHw/VZjSyZwZi8uuCY7UnGC8Q7SxsAF\r
+       joWKCXKW3qZCbvuQAU8wVpuU3QEuiM/7Tj62U=\r
+Received: by 10.204.143.131 with SMTP id v3mr7916178bku.83.1327900971776;\r
+       Sun, 29 Jan 2012 21:22:51 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id bw9sm35098339bkb.8.2012.01.29.21.22.50\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 29 Jan 2012 21:22:51 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH v2 10/13] emacs: use message ids instead of thread id in\r
+       `notmuch-show-operate-all'\r
+In-Reply-To: <20120130045709.GN17991@mit.edu>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327890382-548-11-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <20120130045709.GN17991@mit.edu>\r
+User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 30 Jan 2012 09:21:41 +0400\r
+Message-ID: <87k44922ai.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 05:22:55 -0000\r
+\r
+On Sun, 29 Jan 2012 23:57:09 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Quoth Dmitry Kurochkin on Jan 30 at  6:26 am:\r
+> > Before the change, `notmuch-show-operate-all' used thread id for\r
+> \r
+> notmuch-show-tag-all?\r
+> \r
+\r
+ouch\r
+\r
+> > "notmuch tag" search.  This could result in tagging unexpected\r
+> > messages that were added to the thread after the notmuch-show buffer\r
+> > was created.  The patch changes `notmuch-show-operate-all' to use ids\r
+> > of shown messages to fix this.\r
+> > ---\r
+> \r
+> If you move this patch before the one that introduces\r
+> notmuch-show-tag-all, you could do it this way from the beginning.\r
+> \r
+\r
+This patch can not be moved before the one that introduces\r
+`notmuch-show-tag-all', because it changes `notmuch-show-tag-all'.\r
+Perhaps you meant to factor out `notmuch-show-mapc' and\r
+`notmuch-show-get-messages-ids-search' into a separate patch(es), but I\r
+am too lazy.\r
+\r
+I merged this patch into the one which introduces\r
+`notmuch-show-tag-all'.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> >  emacs/notmuch-show.el |   23 ++++++++++++++++++++++-\r
+> >  1 files changed, 22 insertions(+), 1 deletions(-)\r
+> > \r
+> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> > index 0d90c1e..b115a8f 100644\r
+> > --- a/emacs/notmuch-show.el\r
+> > +++ b/emacs/notmuch-show.el\r
+> > @@ -1170,6 +1170,15 @@ All currently available key bindings:\r
+> >      (notmuch-show-move-to-message-top)\r
+> >      t))\r
+> >  \r
+> > +(defun notmuch-show-mapc (function)\r
+> > +  "Iterate through all messages in the current thread with\r
+> > +`notmuch-show-goto-message-next' and call FUNCTION for side\r
+> > +effects."\r
+> > +  (save-excursion\r
+> > +    (goto-char (point-min))\r
+> > +    (loop do (funcall function)\r
+> > +    while (notmuch-show-goto-message-next))))\r
+> > +\r
+> >  ;; Functions relating to the visibility of messages and their\r
+> >  ;; components.\r
+> >  \r
+> > @@ -1222,6 +1231,18 @@ Some useful entries are:\r
+> >    "Return the message id of the current message."\r
+> >    (concat "id:\"" (notmuch-show-get-prop :id) "\""))\r
+> >  \r
+> > +(defun notmuch-show-get-messages-ids ()\r
+> > +  "Return all message ids of messages in the current thread."\r
+> > +  (let ((message-ids))\r
+> > +    (notmuch-show-mapc\r
+> > +     (lambda () (push (notmuch-show-get-message-id) message-ids)))\r
+> > +    message-ids))\r
+> > +\r
+> > +(defun notmuch-show-get-messages-ids-search ()\r
+> > +  "Return a search string for all message ids of messages in the\r
+> > +current thread."\r
+> > +  (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))\r
+> > +\r
+> >  ;; dme: Would it make sense to use a macro for many of these?\r
+> >  \r
+> >  (defun notmuch-show-get-filename ()\r
+> > @@ -1494,7 +1515,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+> >  \r
+> >  TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+> >    (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))\r
+> > -  (apply 'notmuch-tag notmuch-show-thread-id tag-changes)\r
+> > +  (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)\r
+> >    (save-excursion\r
+> >      (goto-char (point-min))\r
+> >      (loop do (let* ((current-tags (notmuch-show-get-tags))\r