Re: [PATCH] emacs: push mark before signature on reply

diff --git a/d7/4970aeee04a53bbb60398b4b2b1c04edf177d7 b/d7/4970aeee04a53bbb60398b4b2b1c04edf177d7
new file mode 100644 (file)
index 0000000..4e8f293
--- /dev/null
+++ b/d7/4970aeee04a53bbb60398b4b2b1c04edf177d7
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1DBC1431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 29 Mar 2014 00:08:17 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id OhyvuLVgRXNd for <notmuch@notmuchmail.org>;\r
+       Sat, 29 Mar 2014 00:08:09 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6DC73431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 29 Mar 2014 00:08:09 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 5EDD01000E5;\r
+       Sat, 29 Mar 2014 09:08:03 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: push mark before signature on reply\r
+In-Reply-To: <1396029865-23133-1-git-send-email-jani@nikula.org>\r
+References: <1396029865-23133-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.17+159~gb806a13 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 29 Mar 2014 09:08:03 +0200\r
+Message-ID: <m2vbux1nzg.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 29 Mar 2014 07:08:17 -0000\r
+\r
+On Fri, Mar 28 2014, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> We push mark on reply so user can cut the quote. Push the mark before\r
+> signature, if any, instead of end of buffer so the signature is\r
+> preserved.\r
+>\r
+> This is consistent with message-kill-to-signature.\r
+> ---\r
+\r
+LGTM. +1\r
+\r
+>  emacs/notmuch-mua.el | 6 +++++-\r
+>  1 file changed, 5 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+> index b16a10ecd379..ba3ef275ec5e 100644\r
+> --- a/emacs/notmuch-mua.el\r
+> +++ b/emacs/notmuch-mua.el\r
+> @@ -226,8 +226,12 @@ list."\r
+>      ;; Quote the original message according to the user's configured style.\r
+>      (message-cite-original))))\r
+>  \r
+> -  (goto-char (point-max))\r
+> +  ;; Push mark right before signature, if any.\r
+> +  (message-goto-signature)\r
+> +  (unless (eobp)\r
+> +    (end-of-line -1))\r
+>    (push-mark)\r
+> +\r
+>    (message-goto-body)\r
+>    (set-buffer-modified-p nil))\r
+>  \r
+> -- \r
+> 1.9.0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r