Re: [PATCH v2] emacs: Fix display of highlighted line in notmuch-search

diff --git a/5d/b731b64501d79d1b6d7853f748a3ec70ca2255 b/5d/b731b64501d79d1b6d7853f748a3ec70ca2255
new file mode 100644 (file)
index 0000000..8374a65
--- /dev/null
+++ b/5d/b731b64501d79d1b6d7853f748a3ec70ca2255
@@ -0,0 +1,99 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BA0E4429E42\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 15:27:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QcS-lYSpUVRY for <notmuch@notmuchmail.org>;\r
+       Wed, 15 Feb 2012 15:27:23 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 17B4B431E62\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 15:27:22 -0800 (PST)\r
+Received: by bkcit16 with SMTP id it16so1589642bkc.26\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 15:27:20 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=v8yMQBJXLgNSC79DkRZNJovacLh1u9B7lw/Dt+HsPJY=;\r
+       b=mih0N9cSS453wQRXfy4ZFdHSEhydCih/T553vdRJ0KtmJYVRw1nYiOk5ZanctiNKq7\r
+       9S+5lfvKYqjdr8MWKMtRpB7UgwrKll/sMln5DUTHGzRlqVn22h7bLv4EWsKn7tIPo+/+\r
+       V4enhjVUlFwj75Xe0jfgBTw3MzjwVYbglFjLM=\r
+Received: by 10.205.127.147 with SMTP id ha19mr67794bkc.64.1329348440319;\r
+       Wed, 15 Feb 2012 15:27:20 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id t17sm9317297bke.6.2012.02.15.15.27.19\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 15 Feb 2012 15:27:19 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Michal Sojka <sojka@os.inf.tu-dresden.de>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: Fix display of highlighted line in\r
+       notmuch-search\r
+In-Reply-To: <87ehtvheig.fsf@steelpick.2x.cz>\r
+References: <87mx8lpd5o.fsf@nikula.org>\r
+       <1329239387-6300-1-git-send-email-sojka@os.inf.tu-dresden.de>\r
+       <87wr7ngand.fsf@gmail.com> <87ehtvheig.fsf@steelpick.2x.cz>\r
+User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 16 Feb 2012 03:25:59 +0400\r
+Message-ID: <87ty2rfzlk.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 15 Feb 2012 23:27:26 -0000\r
+\r
+On Thu, 16 Feb 2012 00:18:31 +0100, Michal Sojka <sojka@os.inf.tu-dresden.de> wrote:\r
+> On Wed, 15 Feb 2012, Dmitry Kurochkin wrote:\r
+> > Hi Michal.\r
+> > \r
+> > On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka <sojka@os.inf.tu-dresden.de> wrote:\r
+> > > When notmuch-search-line-faces is used to set background color in search\r
+> > > results, the highlight of the current line is not always displayed\r
+> > > correctly. This patch fixes that by increasing the priority property of\r
+> > > the highlight overlay.\r
+> > > ---\r
+> > \r
+> > How about changing `notmuch-search-color-line' to use text properties\r
+> > instead of overlays?  Then hl-line overlay would take priority over it\r
+> > without these changes.\r
+> > \r
+> > See [1] by David Edmondson on why text properties are better in\r
+> > general.  I plan to use text properties here to simplify updating the\r
+> > face when tags are changed.\r
+> \r
+> Hmm, I always wondered why notmuch uses overlays even if Elisp manual\r
+> says they don't scale. I remember that I wanted to replace that long\r
+> time ago, but there was some problem, which I forgot. Maybe it was the\r
+> invisibility David mentions. I guess there is some invisible text in\r
+> search output, isn't it?\r
+> \r
+\r
+Yes.  Also other faces (e.g. date, subject) are used in search.  If we\r
+used properties in `notmuch-search-color-line', we would have to merge\r
+with other properties.  So I take my proposal back.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> -Michal\r