Re: [PATCH v2 06/10] cli: refactor insert

diff --git a/8c/3f660e2fff968e3fe9bedbf4d339bf13b0ffd3 b/8c/3f660e2fff968e3fe9bedbf4d339bf13b0ffd3
new file mode 100644 (file)
index 0000000..e390384
--- /dev/null
+++ b/8c/3f660e2fff968e3fe9bedbf4d339bf13b0ffd3
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 12E64431FB6\r
+       for <notmuch@notmuchmail.org>; Tue,  8 Jul 2014 16:24:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6eSQfleYeS4i for <notmuch@notmuchmail.org>;\r
+       Tue,  8 Jul 2014 16:24:28 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 73365431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  8 Jul 2014 16:24:28 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1X4ekK-0005UX-1Z; Tue, 08 Jul 2014 20:24:24 -0300\r
+Received: (nullmailer pid 23713 invoked by uid 1000); Tue, 08 Jul 2014\r
+       23:24:20 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Peter Wang <novalazy@gmail.com>\r
+Subject: Re: [PATCH v2 06/10] cli: refactor insert\r
+In-Reply-To: <20140706135728.GE1142@hili.localdomain>\r
+References: <1397653165-15620-1-git-send-email-novalazy@gmail.com>\r
+       <1397653165-15620-7-git-send-email-novalazy@gmail.com>\r
+       <87simgq702.fsf@maritornes.cs.unb.ca>\r
+       <20140706135728.GE1142@hili.localdomain>\r
+User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 08 Jul 2014 20:24:20 -0300\r
+Message-ID: <87a98jwi1n.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 08 Jul 2014 23:24:32 -0000\r
+\r
+Peter Wang <novalazy@gmail.com> writes:\r
+\r
+>> Is there a good reason to use TRUE and FALSE for return values rather\r
+>> than EXIT_SUCCESS and EXIT_FAILURE? It seems like the latter would be\r
+>> overall slightly simpler in notmuch_insert_command.\r
+>\r
+> Not sure what you have in mind.  I think CLI exit codes should be\r
+> confined to notmuch_insert_command.\r
+\r
+I guess I was thinking of the convention of using 0 for success; several\r
+of the internal functions in e.g. notmuch-new.c, notmuch-dump.c an d\r
+notmuch-restore.c and notmuch-tag.c (and of course the notmuch lib)\r
+follow this.\r
+\r
+d\r
+\r