Re: [PATCH] test: make test_expect_equal_file() arguments flexible

diff --git a/99/67e73edba3a7dbb331d7fa4382acf17fb3970c b/99/67e73edba3a7dbb331d7fa4382acf17fb3970c
new file mode 100644 (file)
index 0000000..9258d9c
--- /dev/null
+++ b/99/67e73edba3a7dbb331d7fa4382acf17fb3970c
@@ -0,0 +1,93 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 92CE1431E64\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 02:39:11 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id qvY-Nv8xin0m for <notmuch@notmuchmail.org>;\r
+       Wed,  1 Feb 2012 02:39:09 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 487C5431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 02:39:09 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so976544bke.26\r
+       for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 02:39:06 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=0B5V+AyRbQKBVL2h1R3R06jP6PYH7gD3L+Jn9NUhfXE=;\r
+       b=DjzReOL5+ySOCTONoDA3QFyldiffjiDebJ9Ls5VroaersiHAtp15DCGK0tO3mk8tVc\r
+       8K6YmVLUUtJWFGvj02hdr14ct1nJSzOEs+kzSTiLqDdNkCndWJmgpq2wvBwS8LqR0pDx\r
+       JVSnCC6wSZRJJcV2jf+1mFKyuXjz9UxN0nMTw=\r
+Received: by 10.205.123.2 with SMTP id gi2mr12908554bkc.76.1328092746304;\r
+       Wed, 01 Feb 2012 02:39:06 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id o26sm46985782bko.14.2012.02.01.02.39.05\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 01 Feb 2012 02:39:05 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>,\r
+       Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible\r
+In-Reply-To: <m262fqc0wv.fsf@guru.guru-group.fi>\r
+References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87r4yfszx9.fsf@servo.finestructure.net>\r
+       <87pqdync64.fsf@gmail.com> <m262fqc0wv.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 01 Feb 2012 14:37:53 +0400\r
+Message-ID: <87k446n8ji.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 01 Feb 2012 10:39:11 -0000\r
+\r
+On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> \r
+> There are at least these options here\r
+> \r
+> 1) go through all ~100 places where test_expect_equal_file is used\r
+>    and fix the call order: quick look tells that the offending uses\r
+>    are in dump-restore, hooks, search-limiting and symbol-hiding.\r
+> \r
+> 2) enforce "expected" filename has some format *and* fix all current\r
+>    uses of it. Add testbed_error () function which yells loudly ane exits...\r
+> \r
+> 3) guess which is output and which is expected from args so that \r
+>    machine helps tester here (for both diff output & copied files)a\r
+> \r
+> 4) just copy compared files to some directory, those are named as\r
+>    basename of the original -- diff order still inconsistent.\r
+> \r
+> \r
+> I'd just go with option 1 and fix new *violations* when stumble upon one.\r
+> \r
+\r
+Option 1 does not solve the problem.  New violations would apper and\r
+need to be fixed again.  I am for option 2.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> Tomi\r