Re: [PATCH 1/1] devel/STYLE: information how to enable standard pre-commit hook

diff --git a/dc/0137ae50fff33c896eb0eea4f10de817ba1c40 b/dc/0137ae50fff33c896eb0eea4f10de817ba1c40
new file mode 100644 (file)
index 0000000..7de73e0
--- /dev/null
+++ b/dc/0137ae50fff33c896eb0eea4f10de817ba1c40
@@ -0,0 +1,105 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 45B47431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 26 Mar 2013 02:18:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id gNVPsOnWFYb7 for <notmuch@notmuchmail.org>;\r
+       Tue, 26 Mar 2013 02:18:24 -0700 (PDT)\r
+Received: from mail-we0-f173.google.com (mail-we0-f173.google.com\r
+       [74.125.82.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 24293431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 26 Mar 2013 02:18:24 -0700 (PDT)\r
+Received: by mail-we0-f173.google.com with SMTP id t57so1775938wey.18\r
+       for <notmuch@notmuchmail.org>; Tue, 26 Mar 2013 02:18:21 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=x-received:from:to:cc:subject:in-reply-to:references:user-agent\r
+       :date:message-id:mime-version:content-type:x-gm-message-state;\r
+       bh=fzSu1e20Ut6ClSFOpn5pPQk1CiKq+I34uX8qzt/SOCo=;\r
+       b=ebgFGms3eZ8KkyCyZ6B/ABaZSeD70sU6CeF8o/7C7iDxdYzk/jWwhTi9uaWTFKK1R0\r
+       rUL7oZxcKf9zrpreLeqWFqsbjtp39bL5FRbHLtSKNg1FIQmzjaYzH2Wf7bEIoZ9ZuoSu\r
+       /fOmvV/bAaX5VFqMmCLk1/BZn7ucWJo82M4hERAUC6d99tHlZueUnEYmAu5aB9cGHB9x\r
+       SOASqMOixTkSz66QZQOf/ElrwV+0JDde3EmHl+oL8vCe9I3BK9BaAbZ85MgTgpmuHuok\r
+       i0jBbG0Ju7w0mgtZvc/DdCDWZSo9WKgE3Vgysi44dON0TDO8CNs19fLehV7cVfk4niUI\r
+       Cwfg==\r
+X-Received: by 10.180.73.6 with SMTP id h6mr1708635wiv.27.1364289501718;\r
+       Tue, 26 Mar 2013 02:18:21 -0700 (PDT)\r
+Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])\r
+       by mx.google.com with ESMTPS id t7sm1766790wij.2.2013.03.26.02.18.19\r
+       (version=TLSv1.1 cipher=RC4-SHA bits=128/128);\r
+       Tue, 26 Mar 2013 02:18:20 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/1] devel/STYLE: information how to enable standard\r
+       pre-commit hook\r
+In-Reply-To: <1364040435-22357-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1364040435-22357-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.15.2+34~ga90fdd9 (http://notmuchmail.org) Emacs/23.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 26 Mar 2013 10:18:11 +0100\r
+Message-ID: <87ppymfrjg.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQmzQ0TAj3Ez/AmJQKu15IcOKSxhCbKtRNft8k1mwqhlNOd7TZ4ekbUas04FZrtFWdZT6VJD\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 26 Mar 2013 09:18:25 -0000\r
+\r
+On Sat, 23 Mar 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> It is easier to enable git standard pre-commit hook, when the\r
+> operation to do so is presented.\r
+> ---\r
+>  devel/STYLE | 5 +++--\r
+>  1 file changed, 3 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/devel/STYLE b/devel/STYLE\r
+> index 0792ba1..92de42c 100644\r
+> --- a/devel/STYLE\r
+> +++ b/devel/STYLE\r
+> @@ -45,8 +45,9 @@ function (param_type param, param_type param)\r
+>     - likewise, there is a space following keywords such as if and while\r
+>     - every binary operator should have space on either side.\r
+>  \r
+> -* No trailing whitespace. Please enable the standard pre-commit hook\r
+> -  in git (or an equivalent hook).\r
+> +* No trailing whitespace. Please enable the standard pre-commit hook in git\r
+> +  (or an equivalent hook). The standard pre-commit hook is enabled by simply\r
+> +  renaming file '.git/hooks/pre-commit.sample' to '.git/hooks/pre-commit' .\r
+\r
+<bikeshedding>\r
+\r
+Or just refer to http://git-scm.com/book/en/Customizing-Git-Git-Hooks or\r
+man githooks if you really need to. Older versions of git used to have\r
+properly named hooks with the executable bit unset...\r
+\r
+Personally I wouldn't ask anyone to enable the hook because I wouldn't\r
+enable it in the first place. There's $EDITOR and 'git diff --check' to\r
+do that kind of thing... When I want to commit I want to commit, warts\r
+and all, and I don't want a hook to prevent me from doing so!\r
+\r
+</bikeshedding>\r
+\r
+BR,\r
+Jani.\r