--- /dev/null
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2FBF7431FBF\r
+ for <notmuch@notmuchmail.org>; Thu, 8 May 2014 15:09:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id rUeFe8zQpKxx for <notmuch@notmuchmail.org>;\r
+ Thu, 8 May 2014 15:09:22 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+ [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 0A787431FAE\r
+ for <notmuch@notmuchmail.org>; Thu, 8 May 2014 15:09:22 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+ 4.72) (envelope-from <david@tethera.net>)\r
+ id 1WiWU0-0000NE-FW; Thu, 08 May 2014 22:08:04 +0000\r
+Received: (nullmailer pid 12014 invoked by uid 1000); Thu, 08 May 2014\r
+ 22:07:44 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Charles Celerier <cceleri@cs.stanford.edu>, Notmuch Mail\r
+ <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.\r
+In-Reply-To: <m2zjisnwie.fsf@jane.lan>\r
+References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu>\r
+ <1399434615-28425-1-git-send-email-cceleri@cs.stanford.edu>\r
+ <1399434615-28425-2-git-send-email-cceleri@cs.stanford.edu>\r
+ <87d2fov2qj.fsf@maritornes.cs.unb.ca> <m2zjisnwie.fsf@jane.lan>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 09 May 2014 07:07:44 +0900\r
+Message-ID: <87a9arvs9b.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 May 2014 22:09:28 -0000\r
+\r
+Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+>> Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+>>> test_begin_subtest 'comparing existing to exported symbols'\r
+>>> -objdump -t $TEST_DIRECTORY/../lib/*.o | awk '$4 == ".text" && $6 ~ "^notmuch" {print $6}' | sort | uniq > ACTUAL\r
+>>> +nm -g $TEST_DIRECTORY/../lib/*.o | sed -n 's/.*\s\+T\s\+_\(notmuch_.*\)/\1/p' | sort | uniq > ACTUAL\r
+>>> sed -n 's/[[:blank:]]*\(notmuch_[^;]*\);/\1/p' $TEST_DIRECTORY/../notmuch.sym | sort | uniq > EXPORTED\r
+>>\r
+>> Hmm. It seems like the _ there is wrong. It grabs all of the symbols\r
+>> starting with _notmuch, which are symbols we _don't_ want exported.\r
+>> It makes me wonder what ends up in "notmuch.sym" on MacOS, if that test\r
+>> passes for you.\r
+>\r
+> Ok. Apologies in advance for the verbose content of this email. Here is my notmuch.sym:\r
+\r
+Actually, that's perfect. I think I finally understand what's going on,\r
+if not completely how to fix it yet.\r
+\r
+>\r
+> $ cat notmuch.sym\r
+> {\r
+> global:\r
+\r
+this looks fine; only mangled C++ stuff is different.\r
+\r
+> The output of the test in question (T360-symbol-hiding) after\r
+> applying all of the patches in this series is\r
+>\r
+> T360-symbol-hiding: Testing exception symbol hiding\r
+> PASS running test\r
+> PASS checking output\r
+> FAIL comparing existing to exported symbols\r
+> --- T360-symbol-hiding.3.EXPORTED 2014-05-08\r
+> 14:48:52.000000000 +0000\r
+> +++ T360-symbol-hiding.3.ACTUAL 2014-05-08 14:48:52.000000000\r
+> +0000\r
+> @@ -26,7 +26,11 @@\r
+> notmuch_filenames_valid\r
+> notmuch_message_add_tag\r
+> notmuch_message_destroy\r
+> +notmuch_message_file_close\r
+> +notmuch_message_file_get_header\r
+> +notmuch_message_file_open\r
+>\r
+\r
+OK, what's happening here is that your version of the test, I guess\r
+using nm, is not skipping hidden symbols. This should probably be better\r
+documented in the existing test, but in the case of hidden symbols,\r
+$6 is ".hidden". I don't know if nm understands symbol visibility at\r
+all; I'd guess not.\r
+\r
+So as a more portable workaround, I agree we could start being more\r
+rigorous about not naming things "^notmuch_.*" unless they are intended\r
+to be exported.\r
+\r
+> This output was a clear motivation for the patch in\r
+> id:1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu.\r
+\r
+I see that now. I think I'd prefer a more minimal patch that only adds _\r
+to the front of symbols currently starting with notmuch.\r
+\r
+> Here is some of output of the matches made on the output of nm:\r
+>\r
+> $ nm -g test/../lib/*.o | sed -n '/.*\s\+T\s\+_\(notmuch_.*\)/p'\r
+> 00000000000028c0 T _notmuch_database_add_message\r
+> 0000000000002280 T _notmuch_database_begin_atomic\r
+> 0000000000001af0 T _notmuch_database_close\r
+> 0000000000001de0 T _notmuch_database_compact\r
+\r
+With GNU nm, there is no leading _ in front of notmuch here, which is\r
+what causes your version of the test to fail for me.\r
+\r
+d\r
projects / notmuch-archives.git / commitdiff